Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirements for pull request release to sindresorhus/awesome #3

Closed
8 tasks done
mcanouil opened this issue Aug 1, 2022 · 2 comments
Closed
8 tasks done

Requirements for pull request release to sindresorhus/awesome #3

mcanouil opened this issue Aug 1, 2022 · 2 comments
Assignees

Comments

@mcanouil
Copy link
Owner

mcanouil commented Aug 1, 2022

Requirements for your pull request1

  • Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
    (Requirements for the Awesome list #4)
  • You have to review at least 2 other open pull requests.
    Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
  • You have read and understood the instructions for creating a list.
  • This pull request has a title in the format Add Name of List.
    - ✅ Add Swift
    - ✅ Add Software Architecture
    - ❌ Update readme.md
    - ❌ Add Awesome Swift
    - ❌ Add swift
    - ❌ add Swift
    - ❌ Adding Swift
    - ❌ Added Swift
  • Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.
    - ✅ - [iOS](…) - Mobile operating system for Apple phones and tablets.
    - ✅ - [Framer](…) - Prototyping interactive UI designs.
    - ❌ - [iOS](…) - Resources and tools for iOS development.
    - ❌ - [Framer](…)
    - ❌ - [Framer](…) - prototyping interactive UI designs
  • Your entry should be added at the bottom of the appropriate category.
  • The title of your entry should be title-cased and the URL to your list should end in #readme.
    - Example: - [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
  • The suggested Awesome list complies with the below requirements.

Footnotes

  1. From https://github.com/sindresorhus/awesome/blob/main/pull_request_template.md.

@mcanouil mcanouil self-assigned this Aug 1, 2022
@mcanouil mcanouil changed the title PR to sindresorhus/awesome Requirements for pull request release to sindresorhus/awesome Aug 1, 2022
@mcanouil mcanouil pinned this issue Aug 1, 2022
@mcanouil
Copy link
Owner Author

PR sindresorhus/awesome#2550

@mcanouil mcanouil closed this as completed Jun 2, 2023
@mcanouil mcanouil unpinned this issue Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant