Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: be lenient with config file and assume defaults #106

Open
Atemu opened this issue May 6, 2024 · 1 comment
Open

[Feature request]: be lenient with config file and assume defaults #106

Atemu opened this issue May 6, 2024 · 1 comment

Comments

@Atemu
Copy link

Atemu commented May 6, 2024

Please describe your feature request

Currently, you must manually declare a lot of fields with their default value in order to set any one particular setting or else wluma will crash complaining about a missing field. This is rather annoying.

wluma should be able to start up using an empty config file and any config file where any one setting is set without a whole set of settings present.

@maximbaz
Copy link
Owner

maximbaz commented May 6, 2024

Thanks for the idea! I think it might be a bit tricky, especially with the array fields. Consider if user had this config.toml:

[[output.backlight]]
name = "eDP-2"

Was the intention to edit name in the default backlight, or to have a second output?

Perhaps I should just remove the default config altogether, the only reason it assumes Intel + Dell hardware is because that was the hardware I used to develop wluma 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants