Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: gracefully disable capture when not wlroots #105

Open
Atemu opened this issue May 6, 2024 · 2 comments
Open

[Feature request]: gracefully disable capture when not wlroots #105

Atemu opened this issue May 6, 2024 · 2 comments

Comments

@Atemu
Copy link

Atemu commented May 6, 2024

Please describe your feature request

wluma currently just crashes when ran with default config in anything other than a wlroots compositor. This is not a sane default.

It should instead automatically disable capture and print a log message at worst.

@maximbaz
Copy link
Owner

maximbaz commented May 6, 2024

Thanks! It sounds good, but there are several things we need to be mindful about.

  1. The selling point of the app is screen-contents awareness. I would like people to realize as soon as possible that they can't get what's demonstrated on the gif in README if they don't have the supported setup.
  2. Prediction model assumes "stable" setup per output. If user changes between two compositors (say sway and Gnome) and runs wluma on both of them (i.e. screen data is sometimes present), the model data would be corrupted, resulting in unpredictable behavior.

@Atemu
Copy link
Author

Atemu commented May 22, 2024

The selling point of the app is screen-contents awareness. I would like people to realize as soon as possible that they can't get what's demonstrated on the gif in README if they don't have the supported setup.

That's a really good point.

I use wluma primarily for its auto-brightness feature but content-awareness is certainly a selling point and I'd like to at least try it at some point.

Perhaps a more "in your face" warning about the feature being disabled other than a crash would be appropriate; a desktop notification perhaps?

Such a warning should be accompanied by an easy method to disable content-awareness that does not involve having to specify it for each connected monitor. It'd be great if there could be a "I only want auto-brightness" mode.

  1. Prediction model assumes "stable" setup per output. If user changes between two compositors (say sway and Gnome) and runs wluma on both of them (i.e. screen data is sometimes present), the model data would be corrupted, resulting in unpredictable behavior.

This smells like a design flaw.

Fixing the design flaw would be the proper solution but still a better fallback could be to reset the model when a different compositor is detected or have separate models for each compositor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants