Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta's bugs - Round # 4 #1

Closed
elzadj opened this issue Apr 23, 2024 · 16 comments
Closed

Beta's bugs - Round # 4 #1

elzadj opened this issue Apr 23, 2024 · 16 comments
Assignees

Comments

@elzadj
Copy link
Collaborator

elzadj commented Apr 23, 2024

maxi-blocks/maxi-blocks#5555

@elzadj elzadj self-assigned this Apr 23, 2024
@elzadj
Copy link
Collaborator Author

elzadj commented Apr 23, 2024

Fixed, leaving it open until we test on several sites.

@ckp267
Copy link

ckp267 commented Apr 25, 2024

Here is the summary of issues that need attention in a numbered list, ready to be added to GitHub:

Prompt: Used in Groq Lama 3 70B https://groq.com/ 305.37 Tokens per seconds

Role: Professional QA tester and github issue creators.
Task: please summarize all the issues that need attention in this chat thread

  1. a numbered list so i can add them to github.
  2. Add a placeholder for images when missing.
  3. Note speaker names. Retain key details like browsers etc
    Format: Output numbered list in markdown ready for a github issue.
    (Paste anonymised chat thread)

Issues:

  • 1. Crash in Site Editor: Crash occurs when trying to open the pages view in Firefox. Christiaan, 11:23

    • Browser: Firefox
    • Error: React errors
      firefox_obbfo0NG0Q
  • 2. (Same as point 1) DeadObject error: Error occurs in Firefox. Christiaan, 11:27

    • Browser: Firefox
    • Error: DeadObject
  • 3. (combination of 1 and 6) Slow loading in Firefox: Site Editor loads slowly in Firefox compared to Chrome. Christiaan, 11:42

    • Browser: Firefox
    • Issue: Slow loading
  • 4. Missing image on SEARCH Template: One image is missing on the search page. Christiaan, 11:43

    • Page: SEARCH Template
    • Issue: Missing image
  • 5. Page Editor styles: Page Editor styles are odd, and the title is left-aligned. Christiaan, 11:49

    • Page: Page Editor
    • Issue: Styles and title alignment
  • 6. EDGE EE infinite SVG migrator loop: Infinite SVG migrator loop occurs in EDGE EE, taking around 5 minutes to stop before the console loads for errors. Christiaan, 8 min

    • Browser: Chrome
    • Page: EE
    • Issue: Infinite SVG migrator loop
  • 7. ** infinite Transition attributes migrator loop**: same as previous point, but for Transition attributes migrator.
    msedge_wfGrqF5cJq
    msedge_ZeTPbu4DTM
    msedge_k0a8Xlx0cH

Notes:

  • Browsers: Firefox, Chrome, Edge
  • Pages: Site Editor, EE, 404
  • Speakers: Christiaan, Svitlana, Kyra

@ckp267 ckp267 changed the title Beta's bugs Beta's bugs round 12 Apr 25, 2024
@ckp267 ckp267 changed the title Beta's bugs round 12 Beta's bugs - Round # 3 Apr 25, 2024
@kyrapieterse
Copy link
Contributor

image

@elzadj
Copy link
Collaborator Author

elzadj commented May 7, 2024

  • Customize(r) rename or hide (need to find an alternative to custom css then).
  • New Page editor load delay before you can type / add blocks.
  • Styles for 'Add title' and 'Type / to choose a block' (see above).
  • Theme styles affecting font size for native blocks.
  • Check what we need from the custom SC we provide, maybe we can add it to the default sc.
  • Add default SC styles migrator with styles from the previous point.
  • Insert pattern to a page - click some blocks, they reload on click (check unique id).
  • Open Block inserter - Patterns - click a pattern - nothing happens until it starts rendering. Need to add a loading indicator, or something similar.
  • Check styles for navigation sub-menu in SC
  • FSE - Templates - Add template - there is a weird 'maxi-image-type' appearing, it should not be there.
  • 1-4 seconds of "Server waiting time" on page load
  • Check current author archive with pagination
  • New custom template - patterns pop-up - need titles there
  • Blog Home template and pattern
  • Typography Units Defaults freezes add new page / fse if you have several old patters
  • preview images cache - need to find a way to clear it if we changed the image

@elzadj
Copy link
Collaborator Author

elzadj commented May 20, 2024

CPT templates maxi-blocks/maxi-blocks#5587

@Olekrut
Copy link

Olekrut commented May 31, 2024

native blocks do not have enough settings to remove some styles and fix everything for a really long time, but maybe for example, native content block needs to remove the margin it will definitely be used
image

@ckp267
Copy link

ckp267 commented May 31, 2024

native blocks do not have enough settings to remove some styles and fix everything for a really long time, but maybe for example, native content block needs to remove the margin it will definitely be used image

Have you tried the Styles Section in the site editor? I saw some blocks start styles there.
I wonder if we can update (margin-block-start: 24px) in our theme.json file @elzadj @Olekrut ?

@elzadj
Copy link
Collaborator Author

elzadj commented May 31, 2024

I wonder if we can update (margin-block-start: 24px) in our theme.json file

there is no such thing there, but I can add styles for the entry-content area to make it 0

@ckp267 ckp267 changed the title Beta's bugs - Round # 3 Beta's bugs - Round # 4 Jun 4, 2024
@ckp267
Copy link

ckp267 commented Jun 4, 2024

  1. Block crash
    https://maxitheme.instawp.xyz/wp-admin/post.php?post=18&action=edit

image

image

console logs
index-template-edit-block-crash-chrome-console.txt

error log on theme activation.

[04-Jun-2024 16:30:34 UTC] PHP Deprecated:  Automatic conversion of false to array is deprecated in /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-content/themes/maxiblocks/functions.php on line 489
[04-Jun-2024 16:31:07 UTC] PHP Fatal error:  Uncaught TypeError: array_key_exists(): Argument #2 ($array) must be of type array, WP_REST_Request given in /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-content/plugins/maxi-blocks/core/class-maxi-api.php:594
Stack trace:
#0 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/rest-api/class-wp-rest-server.php(1230): MaxiBlocks_API->post_maxi_blocks_sc_string()
#1 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/rest-api/class-wp-rest-server.php(1063): WP_REST_Server->respond_to_request()
#2 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/rest-api/class-wp-rest-server.php(439): WP_REST_Server->dispatch()
#3 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/rest-api.php(428): WP_REST_Server->serve_request()
#4 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/class-wp-hook.php(324): rest_api_loaded()
#5 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/class-wp-hook.php(348): WP_Hook->apply_filters()
#6 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/plugin.php(565): WP_Hook->do_action()
#7 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/class-wp.php(418): do_action_ref_array()
#8 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/class-wp.php(813): WP->parse_request()
#9 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-includes/functions.php(1336): WP->main()
#10 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-blog-header.php(16): wp()
#11 /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/index.php(17): require('...')
#12 {main}
  thrown in /home/dasaguyuro9895/web/maxitheme.instawp.xyz/public_html/wp-content/plugins/maxi-blocks/core/class-maxi-api.php on line 594


Code editor

<!-- wp:template-part {"slug":"header","theme":"maxiblocks"} /-->

<!-- wp:group {"tagName":"main","align":"full","style":{"spacing":{"padding":{"top":"0","bottom":"0","left":"0%","right":"0%"}}},"layout":{"type":"constrained"}} -->
<main
	class="wp-block-group alignfull"
	style="
		padding-top: 0;
		padding-right: 0%;
		padding-bottom: 0;
		padding-left: 0%;
	"
>
	<!-- wp:post-content {"style":{"spacing":{"blockGap":"0"}}} /-->
</main>
<!-- /wp:group -->

<!-- wp:template-part {"slug":"footer","tagName":"footer","area":"footer","theme":"maxiblocks"} /-->

======

2. Found this pattern export function from "My patterns" but there is no menu item for it? Odd
https://maxitheme.instawp.xyz/wp-admin/edit.php?post_type=wp_block
image

=====
3. Here ui styles are missing for some reason.
blob:https://maxitheme.instawp.xyz/03f61330-570d-4916-9d3d-8ab293cd8dad
image

image

===
4. THIS IS JUST COMMENTARY ON THE POST WRITING EXPERIENCE - not bugs. Just thoughts on how we might improve it.

Made a new blog post and this happened with the single post template.
https://maxitheme.instawp.xyz/hello-world/

image

Realised the blog post template did not have a Gutenberg "Content" area to i tried to add one. Then the bg colour is white - even though i set it to black background ons the content block and on the Column Maxi which contains it. No change.
https://maxitheme.instawp.xyz/hello-world/

Aha i figured it out. In the blog post Editing Experience EE you basically just use text, image, video (not container, row and column). You basically need to imagine the VE Visitor experience side and what it will look like.

A new post https://maxitheme.instawp.xyz/wp-admin/post-new.php
Just gives you nothing - see screenshot. Is this still an FSE ui shortcoming? IE there is no solution for it yet?
image

Feels odd when the single blog post template is not loaded in the EE Visual editor when it is active. It make the writing experience odd. Is there an option to load it in the EE - i'm not sure how it works - just thinking of a way that will improve the user experience cos now its kinda weird. Not sure what can be done - its very different from the classic editor where you have an input field the the post content. When i get a blank page for a post it im srt of still in the "oh i have to design it" mode versus "just start writing. I wonder what we can do to make it more intuitive?

Maybe it should feel more like a Writing Experience?
Lol i found "distraction free mode" under preferences and now i dont even have a save button.

image

Found it - you hover top of the screen then it shows the toolbar. In this view the Maxi Master Toolbar Icon doesn't work.

image

Is there any way for themes or plugins to control the editor styles for the Blog writing Experience?


Ok that's all i have for now. More to follow.

@elzadj
Copy link
Collaborator Author

elzadj commented Jun 5, 2024

Check the plugin notice - Installation button (when the plugin is not installed)

@elzadj
Copy link
Collaborator Author

elzadj commented Jun 5, 2024

  1. Found this pattern export function from "My patterns" but there is no menu item for it? Odd
    https://maxitheme.instawp.xyz/wp-admin/edit.php?post_type=wp_block

screenshot-wordpress local-2024 06 05-12_15_33

@elzadj
Copy link
Collaborator Author

elzadj commented Jun 5, 2024

  1. I can't re-create it on https://maxitheme.instawp.xyz/wp-admin/post.php?post=1&action=edit , would be great to get a video. Note: you can't open a blog, it usually used for iframes in gutenberg https://developer.mozilla.org/en-US/docs/Web/API/Blob

@elzadj
Copy link
Collaborator Author

elzadj commented Jun 5, 2024

Summarizing the issues to fix:

  • Blocks don't work in Template preview from pages maxi-blocks#5570
  • PHP error and deprecated according to the log
  • A delay when creating a new post (it's back again :(((( )
  • margin-block-start for content
  • maxiblocks containers go outside the content container on posts - check the script. This happens when you add a container to a normal blog post (instead of just a text block) when the "single post template" is assigned.
  • I found point 3 problem - its when you edit "my patterns" "Here ui styles are missing for some reason."
    https://maxitheme.instawp.xyz/wp-admin/edit.php?post_type=wp_block
  • Styles for individual categories, etc. templates.
  • loading animation bug (details are below)

@ckp267
Copy link

ckp267 commented Jun 5, 2024

No pulses for me when inserting patterns from blog posts creation flow https://maxitheme.instawp.xyz/wp-admin/post-new.php
Just nothing and then it appears. Then when a try to CTRL A - Delete - then the pulse work when im trying to delete.

Warning: Internal React error: Expected static flag was missing. Please notify the React team.
is the console error. x 27

https://jam.dev/c/701417aa-4b0d-4963-8468-02436a8ea3e2

Same react errors on page creation flow - no pulses. Then when you want to start editing when you click on the block - it pulses just for that block you click on.
https://maxitheme.instawp.xyz/wp-admin/post.php?post=99&action=edit

@elzadj
Copy link
Collaborator Author

elzadj commented Jun 6, 2024

3 problem - its when you edit "my patterns" "Here ui styles are missing for some reason."
https://maxitheme.instawp.xyz/wp-admin/edit.php?post_type=wp_block

Still can't see / re-create it, so a video would be nice 😾

@ckp267
Copy link

ckp267 commented Jun 6, 2024

3 problem - its when you edit "my patterns" "Here ui styles are missing for some reason."
https://maxitheme.instawp.xyz/wp-admin/edit.php?post_type=wp_block

Still can't see / re-create it, so a video would be nice 😾

Now i cannot recreate it either. Move on.

@elzadj elzadj closed this as completed Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants