Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All possible fixes and updates since Nov 2018... #92

Open
wants to merge 95 commits into
base: master
Choose a base branch
from

Conversation

ivankokan
Copy link
Contributor

@ivankokan ivankokan commented Nov 30, 2018

Hi @maxgalbu, are you still following what's going on here?

Resolves #56.
Resolves #79.
Resolves #83.
Resolves #87.
Resolves #88.
Resolves #89.
Resolves #90.
Resolves #95.
Resolves #96.
Resolves #97.
Resolves #99.
Resolves #103.
Resolves #104.
Resolves #106.
Resolves #107.
Resolves #108.

@joshjryan
Copy link

Hi @maxgalbu,
I have been using @ivankokan's branch for the past two weeks, and it successfully handles the exception being thrown when loading thumbnails on the Fire TV (falling back to old functionality of just displaying the home team, instead of creating an image composed of both team logos).

@joshjryan
Copy link

Hi @maxgalbu,
With this merge request from @ivankokan's fork, and the new fixes that have gone into inputstream.adaptive (available in the latest xbmc nighly), this plugin now works on Amazon FireTV Sticks.
It'd be great if we could get this change merged into your official repo, and get it updated in the official Kodi addon repository (where an old version of this plugin is currently listed).
Let me know if there is anything I can do to help.

@joshjryan
Copy link

@ivankokan, because it has been 10 months since @maxgalbu's last commit, do you think we should assume he is no longer supporting this plugin? (if that's the case, @maxgalbu, thank you for all of your work to get this plugin where it is!)

If so, @ivankokan, would you be interested in submitting your repo to kodi to be added to the official repo?
*I don't know if there is a process defined to update https://kodi.tv/addon/plugins-video-add-ons/nba-league-pass to point to your repo.

@ivankokan
Copy link
Contributor Author

Hi @joshjryan, let's wait a bit more for @maxgalbu's answer before making any decision.

@ivankokan
Copy link
Contributor Author

Hi @maxgalbu, are you still following what's going on here?

@maxgalbu
Copy link
Owner

Sorry, I'm no longer following this plugin, do you have the time to take care of it?

@ivankokan
Copy link
Contributor Author

Sorry, I'm no longer following this plugin, do you have the time to take care of it?

It is better that someone takes care than no one - I can give a shot.

@ivankokan
Copy link
Contributor Author

Hi @maxgalbu, how do we "transfer" everything?

@ivankokan
Copy link
Contributor Author

Hi @maxgalbu. I see that the repository can be completely transferred through Settings (https://help.github.com/en/articles/transferring-a-repository). On the other hand, do we need to change things somewhere else within the Kodi community?

@ivankokan
Copy link
Contributor Author

Hi @maxgalbu, any progress?

@ivankokan
Copy link
Contributor Author

Hi @maxgalbu, it would be great if we welcome the new NBA season ready with all updates, fixes, and changes (I guess there are many to be covered as we had streaming issues at the end of last season). How do we "transfer" everything?

@ivankokan
Copy link
Contributor Author

ivankokan commented Oct 2, 2019

@joshjryan, have you tried the preseason, anything critical?

@joshjryan
Copy link

The Nuggets don't start playing games until next week :)
I'll try one of the other games over the next day or two and let you know how it goes.

@ivankokan ivankokan mentioned this pull request Oct 12, 2019
@ivankokan
Copy link
Contributor Author

@maxgalbu Any updates?

@ivankokan
Copy link
Contributor Author

@maxgalbu Please?

Hi @maxgalbu. I see that the repository can be completely transferred through Settings (https://help.github.com/en/articles/transferring-a-repository). On the other hand, do we need to change things somewhere else within the Kodi community?

nre-ableton and others added 7 commits December 28, 2020 15:08
We should treat "show scores" as a cover-all "no spoilers" option. To
that end, team records should not be shown if "show scores" is off, as
this can accidentally reveal game results.
…ords

Don't show team records if show_scores disabled
Handle HLS protocol used for live games
Refactor and enrich media streaming protocols
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment