From 06fcd2d352ee8412f77b46059a263f14edc04c41 Mon Sep 17 00:00:00 2001 From: Tulir Asokan Date: Fri, 9 Aug 2024 23:41:21 +0300 Subject: [PATCH] Apply suggestions from code review --- pkg/signalid/ids.go | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/pkg/signalid/ids.go b/pkg/signalid/ids.go index 1209e90b..99ef7b3e 100644 --- a/pkg/signalid/ids.go +++ b/pkg/signalid/ids.go @@ -40,7 +40,7 @@ func ParseUserID(userID networkid.UserID) (uuid.UUID, error) { } func ParseUserLoginID(userLoginID networkid.UserLoginID) (uuid.UUID, error) { - userID, err := ParseUserLoginID(userLoginID) + userID, err := uuid.Parse(string(userLoginID)) if err != nil { return uuid.Nil, err } @@ -51,10 +51,6 @@ func ParseUserIDAsServiceID(userID networkid.UserID) (libsignalgo.ServiceID, err return libsignalgo.ServiceIDFromString(string(userID)) } -func ParseUserLoginIDAsServiceID(userLoginID networkid.UserLoginID) (libsignalgo.ServiceID, error) { - return libsignalgo.ServiceIDFromString(string(userLoginID)) -} - func ParsePortalID(portalID networkid.PortalID) (userID libsignalgo.ServiceID, groupID types.GroupIdentifier, err error) { if len(portalID) == 44 { groupID = types.GroupIdentifier(portalID)