Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect against duplicate registries. #15

Open
trusktr opened this issue Oct 11, 2017 · 1 comment
Open

Protect against duplicate registries. #15

trusktr opened this issue Oct 11, 2017 · 1 comment

Comments

@trusktr
Copy link

trusktr commented Oct 11, 2017

If more than one library import CustomAttributesRegistry and instantiate it on document, is this okay?

Or should new CustomAttributesRegistry(document) return the existing registry for the given document if it already exists, like singletons per document?

@matthewp
Copy link
Owner

I think they should probably be unique, i'm just not sure it's this library's job to guard against this mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants