Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root post with reply should not show the thread footer (with replies) in search RHS with CRT on #26916

Open
mattermod opened this issue Apr 29, 2024 · 2 comments
Assignees
Labels
Difficulty/2:Medium Medium ticket Help Wanted Community help wanted Tech/ReactJS Web app

Comments

@mattermod
Copy link
Contributor

Steps to reproduce:

  1. Make sure CRT is on.
  2. Create a new post, and have another user reply to that post.
  3. Open the search, and search for the original post.

Expected: Threads footer should not be shown in the RHS search results.

Observed: Root post shows threads footer if it has replies. See screenshot:

To fix this, we will need to hide that footer for replies when we know the post component is being rendered in the search RHS. There is also a test that can be removed once this is fixed (should have a comment on it)


If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-53078

@mattermod mattermod added Help Wanted Community help wanted Up For Grabs labels Apr 29, 2024
@fasal26
Copy link

fasal26 commented May 1, 2024

Hey I would like to take this

@fasal26
Copy link

fasal26 commented May 4, 2024

@amyblais @mattermod

can anyone of you please provde the expected UI screenshot, I didnt get the below point
Expected: Threads footer should not be shown in the RHS search results.

what does "Threads footer" means ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/2:Medium Medium ticket Help Wanted Community help wanted Tech/ReactJS Web app
Projects
None yet
Development

No branches or pull requests

4 participants