Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR] Resolved automatic tz not reflecting without refresh by listening to app visibility event #26957

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[PR] Resolved automatic tz not reflecting without refresh by listening to app visibility event #26957

wants to merge 4 commits into from

Conversation

fasal26
Copy link

@fasal26 fasal26 commented May 5, 2024 •
edited by hanzei

Summary

Resolved automatic tz not reflecting without refresh by listening to app visibility event

Ticket Link

Fixes #26911

Release Note

Added visibilitychange js browser event for updating user's current timeZone

@mm-cloud-bot
Copy link

@fasal26: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

@mattermost-build
Copy link
Contributor

Hello @fasal26,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@hanzei hanzei requested review from larkox and hmhealey May 6, 2024 07:26
@hanzei hanzei added the 2: Dev Review Requires review by a developer label May 6, 2024
@mm-cloud-bot mm-cloud-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed labels May 6, 2024
@hanzei hanzei added the 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review label May 6, 2024
@unified-ci-app
Copy link
Contributor

unified-ci-app bot commented May 6, 2024

Enterprise tests are not yet completed. You need to wait until Enterprise CI/docker-image status check is successful, before triggering E2E tests.

larkox
larkox approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart of the linting issues, look good to me.

@fasal26
Copy link
Author

fasal26 commented May 11, 2024

Apart of the linting issues, look good to me.

@larkox
linting issues resolved

@hmhealey
Copy link
Member

hmhealey commented May 13, 2024 •
edited

Some of the issues have been resolved, but the linter that you used reorganized the imports in a way that don't match our linting rules. Would you mind fixing those as well?

ESLint should be able to fix those automatically if you run npm run fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkox larkox larkox approved these changes

@hmhealey hmhealey Awaiting requested review from hmhealey

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
2: Dev Review Requires review by a developer 3: QA Review Requires review by a QA tester. May occur at the same time as Dev Review Contributor release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatic time zone is not updated without refreshing page
6 participants
@fasal26 @mm-cloud-bot @mattermost-build @hmhealey @larkox @hanzei