API: "Get posts for a channel" always shows 'has_next' as false

[mattermod]

When using the Get posts for a channel API call, the response includes a has_next attribute, which is supposed to indicate if more pages are available. In my testing (on Mattermost v9.5.3) it always returns false. In the example here:

{
  ...
    "next_post_id": "ggwusis3ufgeinank878k7dq4h",
    "prev_post_id": "onhx6rnrbib3tfqmnmgostcy1r",
    "has_next": false,
    "first_inaccessible_post_time": 0
}

you can see both the next_post_id and prev_post_id fields are populated, and there are definitely more pages available, yet the has_next field remains steadfastly as false.

---

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-57937

[agnivade]

The objective for this ticket is to change the HasNext attribute in

mattermost/server/public/model/post_list.go

Line 18 in 30d450c

HasNext bool `json:"has_next"`

to have omitempty and change it to a pointer.

And then change the code in the sqlstore/post_store.go to appropriately dereference the pointer and set it.

Also, please add a test to ensure that getPostsForChannel API endpoint and probably others don't return the has_next field.

[Aryakoste]

Hello @mattermod. I would like to work on this issue.