Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add screenshots of awesome readmes #1

Open
matiassingers opened this issue Jan 19, 2015 · 11 comments
Open

Add screenshots of awesome readmes #1

matiassingers opened this issue Jan 19, 2015 · 11 comments

Comments

@matiassingers
Copy link
Owner

Not sure about this, but could be interesting to do.


What do you guys think?

@sindresorhus
Copy link

👍 I was going to suggest that.

@cheeaun
Copy link

cheeaun commented Jan 22, 2015

👍

@matiassingers
Copy link
Owner Author

@sindresorhus @cheeaun how would you show the screenshots?

Was thinking about a table, and then maybe a cropped screenshot - but looks a little clunky.

@sindresorhus
Copy link

Nah, tables are ugly. Just resize it to a retina thumbnail.

@RichardLitt
Copy link
Contributor

This would confer the benefit of freezing the README in a point of time. At the moment, it is easy for the README to change such that it might not be awesome anymore.

@deltaidea
Copy link

You could use the <details> tag to hide the screenshots.

Example

  • Example without a screenshot - foo
  • Example with a screenshot - bar
  • Example without a screenshot - qux

Code

* Example without a screenshot - foo
* <details>
    <summary>Example with a screenshot - bar</summary>
    <img src="https://imgs.xkcd.com/comics/random_number.png">
  </details>
* Example without a screenshot - qux

@RichardLitt
Copy link
Contributor

@deltaidea that sounds like a great idea. Any chance you'd like to submit a PR?

@deltaidea
Copy link

Sure, maybe later today. Not with all screenshots at once, though, as that's a lot of work. 😄

@deltaidea
Copy link

Wait, I just realized that if we want to preserve a particular version of a readme, we could just link to it with current commit in the URL, like this:
https://github.com/sindresorhus/pageres/blob/7576249b66accd3fb832dc7b65925aa95978ed2a/readme.md
This would be considerably easier to do, and the markdown in our list would remain simple and contributor-friendly.

There're two issues with this approach that are solved by screenshots:

  • Badges and other external images may become unreachable and break the visual style.
  • Repos can be deleted, in which case the links will still be dead.

@RichardLitt
Copy link
Contributor

@deltaidea Hmm. How about we link to the commit, and show the image as a screenshot? I think that would solve both of the issues, and allow us to content address it.

Thank you for helping with this!

jeo19 added a commit to jeo19/awesome-readme that referenced this issue Jan 21, 2019
@rayhanadev rayhanadev pinned this issue May 9, 2021
@rayhanadev
Copy link
Collaborator

Just to revive this, I've noticed somewhere else that they have users submit an image preview with certain dimensions in addition to a link to their repository. Perhaps we can do something like that?

@Robson Robson unpinned this issue Jun 16, 2022
Robson added a commit that referenced this issue Jun 16, 2022
Convert redirects into direct links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants