Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonlinear minimizers don't allow mixing of bounded and unbounded parameters #931

Open
AutWint opened this issue Jun 22, 2022 · 1 comment · May be fixed by #932
Open

Nonlinear minimizers don't allow mixing of bounded and unbounded parameters #931

AutWint opened this issue Jun 22, 2022 · 1 comment · May be fixed by #932

Comments

@AutWint
Copy link

AutWint commented Jun 22, 2022

Fit model parameters may optionally be box constrained for nonlinear minimization (see e.g. NonlinearMinimizerBase.cs). However, a current limitation is that one has to either provide a full set of lower and/or upper bounds, or leave all parameters unbounded (in any direction).

Sometimes it makes sense for some parameters to be bounded, e.g. due to physical constraints, while it doesn't make sense for others. It would be great if it was possible to mix bounded and unbounded parameters. This could, for instance, be implemented by allowing individual bounds to be nullable, and then checking/catching the individual "null-bounds" in the ProjectToInternalParameters method.

@AutWint
Copy link
Author

AutWint commented Jul 4, 2022

I've created a pull request solving the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant