-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let's set up a modern Rollup-based build system #76
Comments
I'd love to see a modern Rollup-based build setup! Would you be willing to submit a PR? |
OK, I'll try. @mathiasbynens are you happy to also start using |
I'd prefer separating the two. Let's keep the Rollup patch as small as possible, and then consider prettier as a separate follow-up patch. |
Duly noted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related to #64, we should remove all UMD and iife-related code and leave it for Rollup to produce UMD, CJS and EMS builds. Along the way, we could rebase the source to be in ES6+ and keep the source in ES Modules format so that importing parties could benefit from tree-shaking etc. Publishing methods as separate packages (lodash-style) is also an option which would solve #64.
Currently, the iife wrapper in the source contains
this
and it throws errors in Rollup:That's what I'm talking about — if we cleaned the source to be in ES Modules (with
import
/export
) and left up to Rollup to produce the UMD build, we could improve the user experience.The fork https://www.npmjs.com/package/lean-he already went to the right direction, removing the iife wrapper but it still lacks proper Rollup setup with UMD, CJS and ESM builds.
@mathiasbynens please advise, do you see value in this path or should we forget about setting up the Rollup and close this issue.
The text was updated successfully, but these errors were encountered: