-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Child row of a child row does not show "Are you sure you want to delete this row?" #830
Comments
I'll take a look |
With new CodeSandbox rules, I'm not sure you can get to that sandbox now? |
Yes I cant see it. Thats annoying.. |
Should be able to see it now. They defaulted to everything to be private, and I just made it public. |
Thanks, Ill check it out. |
This is defiantly something to do with using parent/child. For some reason, the delete text just isn't inserted. I've been looking through code, but haven't been able to find anything obvious as of yet. |
In MTableEditRow, the localization that is passed on non group rows and the nested child rows are coming through differently. I'm trying to trace through where it is getting the different localization objects. MTableEditRow: Other edit rows when deleting, the localization.deleteText is displayed: when it's child of child, there is no localization.deleteText in this object, but it's in localization.editRow.deleteText.... |
That seems like an easy fix. Would you mind creating a PR to address this? |
I will create one tonight. If found that if in MTableBodyRow I pass localization.editRow in the create element, it looks to work in every instance. |
Describe the bug
When using the parent/child option, a child of a child with children will not show the deletion text "Are you sure you want to delete this row?"
To Reproduce
https://codesandbox.io/p/sandbox/material-table-core-parent-child-forked-8rk59g
Expected behavior
Expected to see the default "Are you sure you want to delete this row?" text.
Screenshots
Desktop:
The text was updated successfully, but these errors were encountered: