-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indicate version of MDC Web somewhere within the catalog #158
Comments
@kfranqueiro Thoughts on getting it directly from the https://github.com/material-components/material-components-web-catalog/compare/feat/version?expand=1 If we really want it from the |
Yeah, I originally contemplated getting it from package.json...I was hoping we could depend on the overall material-components-web package to make this simple, but I think that may be infeasible because of how npm sometimes installs nested dependencies. Maybe we can do something in |
It may be useful for people to be able to be reminded at a glance of what version of MDC Web the catalog is demonstrating. We should be able to populate a single variable in
constants.js
for this and display it somewhere. (Bottom of page? Right side of top app bar?)Originally, I was hoping we could switch to depending on the roll-up package and scan that dependency to auto-generate this, but that's not feasible due to recursive
node_modules
.Ideally we should probably script a way to update all dependencies and the displayed version each time we want to upgrade the catalog to a new MDC Web release. Initially, the process of updating both
package.json
and the displayed version will need to be manual.The text was updated successfully, but these errors were encountered: