-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle svg converter into Matter #46
Comments
Do you want to replace the external dependency on the command |
Yes! the target is to
I'll assign this issue to you then. Thanks! |
Hi, are there any updates to this issue? I have weird problem with the icons on the grub menu. Icons that are more complex, such as Windows and Ubuntu are not being converted properly. I digged around and found out this problem is due to ImageMagick's convert command not working properly, not a bug in Matter. I am putting this issue here because this bug should go away if Matter's dependency on ImageMagick is removed. |
Do you have Inkscape installed? ImageMagick tries to use the Inkscape SVG converter and if it does not find it uses its own converter which is not the best. Your PNG output looks like it is not using Inkscape's converter. See ImageMagick/ImageMagick#2216 for more information about that. |
You were right, using --verbose on the convert command showed it was using its internal converter and not inkscape, which was least expected to me because I have inkscape installed. I spend two hours figuring out how to get it to use inkscape (including building ImageMagick-7 from source, using the Magick's AppImage and tweaking the delegates config) to no avail. I shall patiently wait for matter's own converter to be bundled instead :D |
Oof! Sorry for that, what distro are you using? Maybe it would be better to open a new issue for tracking this particular problem. |
I've got a partial solution to remove the ImageMagick dependency. Do take a look at this branch :D |
That's very nice! |
What do you think about the lxml dependency required? |
I think it would be better to use the Though if there is a reason for using lxml instead let me know. |
Other changes: - Edited main script to prioritise using inkscape, but will fallback to ImageMagick's convert if inkscape not found.
Partial solution to remove ImageMagick dependency (#46)
As of now Matter has two dependencies.
convert
command for convertig icons in svg to pngThese packages seem to be bringing a lot of trouble, it would be great to have an svg converter bundled directly into Matter so that there would be no more problems with dependencies.
The text was updated successfully, but these errors were encountered: