Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contrast calculation needs point size, but is given pixels #485

Open
matatk opened this issue Sep 24, 2022 · 0 comments
Open

Contrast calculation needs point size, but is given pixels #485

matatk opened this issue Sep 24, 2022 · 0 comments
Labels
bug

Comments

@matatk
Copy link
Owner

matatk commented Sep 24, 2022

The threshold for the font colour decision requires font sizes to be expressed in points, but the rest of the codebase and UI takes the font size as being in pixels. Oops :-).
@matatk matatk added the bug label Sep 24, 2022
@matatk matatk mentioned this issue Sep 24, 2022
Closed
matatk added a commit that referenced this issue Sep 25, 2022
@matatk
fix: Assume 1pt is 1.33px
48e2530 
Not the best solution, but this seems unreasonably complicated, so just
doing this for now. This will flip the label colour when the user has
the default settings.

Fixes #485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matatk