Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pound and Euro currency required #565

Open
chsagar236 opened this issue Sep 23, 2021 · 5 comments
Open

Pound and Euro currency required #565

chsagar236 opened this issue Sep 23, 2021 · 5 comments

Comments

@chsagar236
Copy link

hi am sagar, am updating changes and committing code, but code not committed through git

subject and type missing like error showing

@mastermunj
Copy link
Owner

Hi @chsagar236, you should try npm run commit and follow the steps there to help you with proper commit message.

@chsagar236
Copy link
Author

chsagar236 commented Sep 23, 2021

Hi @chsagar236, you should try npm run commit and follow the steps there to help you with proper commit message.

npm run commit done succesfully , when will update these changes, am only added for pound only now, after update i will add for Euro also

@mastermunj
Copy link
Owner

Sure. If you want to do both changes separately, feel free to raise a PR for one.

@rhyso
Copy link
Contributor

rhyso commented Feb 3, 2022

@mastermunj @chsagar236 I was going to open a pull request to add the GB local/pound currency but saw this open issue. Is this going to gain any traction or should I open a new pull request against this ticket?

@mastermunj
Copy link
Owner

@rhyso Thank you for raising PR for GB Pound.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants