From dc28423a7f9672c56949af8fd5ac7086de452317 Mon Sep 17 00:00:00 2001 From: capdiem Date: Mon, 9 Dec 2024 09:51:35 +0800 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20fix(TextField):=20failed=20to=20?= =?UTF-8?q?set=20max=20and=20min=20values=20(#2274)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../Components/Input/MInput.Validatable.cs | 12 +++++-- .../Components/TextField/MTextField.razor.cs | 34 ++++++++++++------- 2 files changed, 32 insertions(+), 14 deletions(-) diff --git a/src/Masa.Blazor/Components/Input/MInput.Validatable.cs b/src/Masa.Blazor/Components/Input/MInput.Validatable.cs index c33479fe5b..15ba04863f 100644 --- a/src/Masa.Blazor/Components/Input/MInput.Validatable.cs +++ b/src/Masa.Blazor/Components/Input/MInput.Validatable.cs @@ -54,10 +54,18 @@ public virtual TValue? Value private EditContext? _prevEditContext; private InternalValueChangeType _changeType; - protected virtual void UpdateInternalValue(TValue? value, InternalValueChangeType changeType) + protected virtual void UpdateInternalValue(TValue? value, InternalValueChangeType changeType, bool force = false) { _changeType = changeType; - InternalValue = value; + + if (force) + { + OnInternalValueChange(value); + } + else + { + InternalValue = value; + } } protected virtual TValue? DefaultValue => default; diff --git a/src/Masa.Blazor/Components/TextField/MTextField.razor.cs b/src/Masa.Blazor/Components/TextField/MTextField.razor.cs index 3d7e8a53e5..df62384e36 100644 --- a/src/Masa.Blazor/Components/TextField/MTextField.razor.cs +++ b/src/Masa.Blazor/Components/TextField/MTextField.razor.cs @@ -541,9 +541,9 @@ private async Task HandleOnInputOrChangeEvent(ChangeEventArgs args, EventCallbac } } - protected override void UpdateInternalValue(TValue? value, InternalValueChangeType changeType) + protected override void UpdateInternalValue(TValue? value, InternalValueChangeType changeType, bool force = false) { - base.UpdateInternalValue(value, changeType); + base.UpdateInternalValue(value, changeType, force); if (IsNumeric(value, out var numeric)) { @@ -568,12 +568,15 @@ private bool IsNumeric(TValue? value, out IConvertible numeric) protected override TValue? ConvertAndSetValueByJSInterop(TValue? val) { - if (Props.Precision.HasValue && IsNumeric(val, out var numeric)) + if (IsNumeric(val, out var numeric)) { var decimalValue = Convert.ToDecimal(numeric, CultureInfo.InvariantCulture); - var newValue = Math.Round(decimalValue, Props.Precision.Value); - _ = SetValueByJsInterop(newValue.ToString(Props.PrecisionFormat, CultureInfo.InvariantCulture)); - return (TValue)Convert.ChangeType(newValue, typeof(TValue), CultureInfo.InvariantCulture); + if (Props.Precision.HasValue) + { + var newValue = Math.Round(decimalValue, Props.Precision.Value); + _ = SetValueByJsInterop(newValue.ToString(Props.PrecisionFormat, CultureInfo.InvariantCulture)); + return (TValue)Convert.ChangeType(newValue, typeof(TValue), CultureInfo.InvariantCulture); + } } return base.ConvertAndSetValueByJSInterop(val); @@ -598,8 +601,15 @@ private void UpdateValue(string? originValue, bool succeeded, TValue? convertedV if (succeeded) { _badInput = false; - var validValue = GetValidValue(convertedValue); - UpdateInternalValue(validValue, InternalValueChangeType.Input); + + // the value would be changed internally if it's out of range, + // so we need to update the change type to InternalOperation + var (validValue, changed) = GetValidValue(convertedValue); + + UpdateInternalValue( + validValue, + changed ? InternalValueChangeType.InternalOperation : InternalValueChangeType.Input, + changed); } else { @@ -621,7 +631,7 @@ private void UpdateValue(string? originValue, bool succeeded, TValue? convertedV } } - private TValue GetValidValue(TValue val) + private (TValue value, bool changed) GetValidValue(TValue val) { if (IsNumeric(val, out var numeric)) { @@ -629,16 +639,16 @@ private TValue GetValidValue(TValue val) if (Props.Min.HasValue && decimalValue < Props.Min) { - return (TValue)Convert.ChangeType(Props.Min, typeof(TValue), CultureInfo.InvariantCulture); + return ((TValue)Convert.ChangeType(Props.Min, typeof(TValue), CultureInfo.InvariantCulture), true); } if (Props.Max.HasValue && decimalValue > Props.Max) { - return (TValue)Convert.ChangeType(Props.Max, typeof(TValue), CultureInfo.InvariantCulture); + return ((TValue)Convert.ChangeType(Props.Max, typeof(TValue), CultureInfo.InvariantCulture), true); } } - return val; + return (val, false); } public async Task HandleOnKeyUpAsync(KeyboardEventArgs args)