-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed change: Dimensions API to the useWindowDimensions hook. #134
Comments
Did you applied this change ? |
I did locally in a project where I use this package and it works. |
Can you explain me how you apply the change ? I tried without success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey there @marudy,
I love this package and the work that has been put into it.
I have a suggestion about moving from the Dimensions API provided by react-native to the useWindowDimensions hook newly provided by react native, as this automatically updates width and height values when screen size changes. I believe this eliminates the need for an event listener to detect when screen dimensions have changed(landscape/portrait). If you concur with this, I can raise a PR to this effect.
The text was updated successfully, but these errors were encountered: