-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for internal objects that implement IRequest. #118
Comments
Hey, sorry about the late reply, I've started work on improving this as suggested in #131 |
This is available in 3.0.0-preview.15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Over the years, I have come across many projects in which:
IRequest
) were stored in the Domain layerIMediator.Send
in the Presentation layer.All the listed objects have an internal access modifier, and the
.csproj
files specify theInternalsVisibleTo
tag up to the overlying layers.At the moment, in my current company, migration from Jimmy Bogart's MediatR to the current implementation is being discussed due to its advantages; however, the problem described above forces us, for the time being, to refrain from that.
Description of the problem
In cases where internal Handler, internal request, and internal response are used,
Inconsistent accessibility
occurs. The problem is that the generatedMediator.Send
method is public, when it's input parameter and return value are internal.Handler
Request
Response
Mediator.Send
Intended solution
Based on the access modifier of the object implementing the
IRequest
, set the necessary overload of theIMediator.Send
method with the corresponding access modifier.The text was updated successfully, but these errors were encountered: