Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile failed on msvc v90 #43

Open
Elite-stay opened this issue Jan 24, 2022 · 1 comment
Open

Compile failed on msvc v90 #43

Elite-stay opened this issue Jan 24, 2022 · 1 comment

Comments

@Elite-stay
Copy link

Elite-stay commented Jan 24, 2022

No std::add_pointer, std::is_same and std::enable_if but have std::tr1::add_pointer and std::tr1::is_same. I modify macro and compile successfully:

#define variant_HAVE_CONDITIONAL        variant_CPP11_120
#define variant_HAVE_REMOVE_CV          variant_CPP11_120
#define variant_HAVE_STD_ADD_POINTER    variant_CPP11_100 // <--
#define variant_HAVE_TYPE_TRAITS        variant_CPP11_90
#define variant_HAVE_ENABLE_IF          variant_CPP11_100 // <--
#define variant_HAVE_IS_SAME            variant_CPP11_100 // <--

#define variant_HAVE_TR1_TYPE_TRAITS    (!! variant_COMPILER_GNUC_VERSION )
#define variant_HAVE_TR1_ADD_POINTER    (!! variant_COMPILER_GNUC_VERSION || variant_CPP11_90 ) // <--

But I'm not sure my std headers is correct.

@martinmoene
Copy link
Owner

Thanks @Elite-stay, looks like it now works with MSVC 9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants