Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixnut padajuce testy #280

Open
32 of 41 tasks
martinmacko47 opened this issue May 15, 2020 · 7 comments
Open
32 of 41 tasks

Fixnut padajuce testy #280

martinmacko47 opened this issue May 15, 2020 · 7 comments
Assignees
@viliambalaz
Labels
issue: task part: tests

Comments

@martinmacko47
Copy link
Owner

martinmacko47 commented May 15, 2020 •
edited
Loading

  • V prvom PR si spust lokalne vsetky testy a padajuce testy s dekoratorom @skip. Testy sa pustaju pomocou env/bin/python manage.py test

  • V druhom PR rozbehaj CI na githube. Aby sa po kazdom pushnutom commite automaticky na githube spustili testy. Ak si nebudes vediet rady, googli. Na githube som CI este nerozbehaval. Ale v principe by malo stacit vytvorit subor .github/workflows/main.yml s popisom CI. Ciel je, aby v kazdom PR bol check, ci testy zbehli a nedovolito to PR mergnut ak testy nezbehli.

  • Potom dalej v samostatnych PR si zober jednu skupinu testov a padajuce testy fixni. V kazdom PR si zober napr. jeden adresar z poleno/, alebo jednu app z chcemvediet/apps/. Pripadne len jeden subor s testami, ak je tam vela parajucich testov.

    • poleno/utils/tests/test_forms.py
    • poleno/utils/tests/test_http.py
    • poleno/utils/tests/test_misc.py
    • poleno/utils/tests/test_models.py
    • poleno/utils/tests/test_views.py
    • poleno/attachments/tests/test_forms.py
    • poleno/attachments/tests/test_models.py
    • poleno/attachments/tests/test_views.py
    • poleno/mail/tests/test_backend.py
    • poleno/mail/tests/test_imap.py
    • poleno/mail/tests/test_mandrill.py
    • poleno/mail/tests/test_models.py
    • poleno/mail/tests/test_smtp.py
    • chcemvediet/apps/accounts/tests/test_forms.py
    • chcemvediet/apps/accounts/tests/test_views.py
    • chcemvediet/apps/inforequests/tests/test_cron.py
    • chcemvediet/apps/inforequests/tests/test_signals.py
    • chcemvediet/apps/inforequests/tests/test_models/test_action.py
    • chcemvediet/apps/inforequests/tests/test_models/test_action_draft.py
    • chcemvediet/apps/inforequests/tests/test_models/test_branch.py
    • chcemvediet/apps/inforequests/tests/test_models/test_inforequest.py
    • chcemvediet/apps/inforequests/tests/test_models/test_inforequest_draft.py
    • chcemvediet/apps/inforequests/tests/test_models/test_inforequest_email.py
    • chcemvediet/apps/inforequests/tests/test_views/test_add_smail.py
    • chcemvediet/apps/inforequests/tests/test_views/test_attachments.py
    • chcemvediet/apps/inforequests/tests/test_views/test_create.py
    • chcemvediet/apps/inforequests/tests/test_views/test_decide_email.py
    • chcemvediet/apps/inforequests/tests/test_views/test_decide_email_unknown.py
    • chcemvediet/apps/inforequests/tests/test_views/test_decide_email_unrelated.py
    • chcemvediet/apps/inforequests/tests/test_views/test_delete_draft.py
    • chcemvediet/apps/inforequests/tests/test_views/test_detail.py
    • chcemvediet/apps/inforequests/tests/test_views/test_extend_deadline.py
    • chcemvediet/apps/inforequests/tests/test_views/test_mine.py
    • chcemvediet/apps/inforequests/tests/test_views/test_new_action.py
    • chcemvediet/apps/obligees/tests/test_forms.py
    • chcemvediet/apps/obligees/tests/test_models.py
    • chcemvediet/apps/obligees/tests/test_views.py
    • chcemvediet/tests/test_views.py

Pri niektorych testoch bude jasne, co sa v kode zmenilo a ako testy treba upravit. Pri niektorych testoch to nemusi byt uplne jasne. Kde to nie je jasne, mozeme si k tomu zavolat a zamysliet sa nad tym.
@martinmacko47 martinmacko47 added this to the 2020 milestone May 15, 2020
@martinmacko47 martinmacko47 mentioned this issue May 15, 2020
Open
viliambalaz added a commit that referenced this issue Jun 10, 2020
@viliambalaz
#280 Skip obligee tests
72ffc67 
#280 Skip te
viliambalaz added a commit that referenced this issue Jun 10, 2020
@viliambalaz
#280 Skip inforequests tests
b65d1e6
viliambalaz added a commit that referenced this issue Jun 10, 2020
@viliambalaz
#280 Skip accounts tests
81b5796
viliambalaz added a commit that referenced this issue Jun 10, 2020
@viliambalaz
#280 Skip chcemvediet tests
db78b48
viliambalaz added a commit that referenced this issue Jun 10, 2020
@viliambalaz
#280 Skip poleno tests
9d1c2b0
@martinmacko47
Copy link
Owner Author

martinmacko47 commented Jun 11, 2020 •
edited
Loading

Pri opravovani existujucich testov bude asi lahsie zacat od testov v adresari /poleno, kedze tam su vseobecnejsie utility.

Edit: ✔️

viliambalaz added a commit that referenced this issue Jun 11, 2020
@viliambalaz
#280 Fix tests (#286)
9f7e770 
* #280 Skip obligee tests

* #280 Skip inforequests tests

* #280 Skip accounts tests

* #280 Skip chcemvediet tests

* #280 Skip poleno tests
viliambalaz added a commit that referenced this issue Jun 13, 2020
@viliambalaz
#280 Add main.yml
ae4e200
viliambalaz added a commit that referenced this issue Jun 25, 2020
@viliambalaz
#280 Edit main.yml
90173e3
viliambalaz added a commit that referenced this issue Jun 25, 2020
@viliambalaz
#280 Use raw_input instead getpass.getpass
e5ecb9d
viliambalaz added a commit that referenced this issue Jun 25, 2020
@viliambalaz
#280 Install requirements for unittesting
13d60a7
viliambalaz added a commit that referenced this issue Jun 25, 2020
@viliambalaz
#280 Install requirements for unittesting
0d579d5
viliambalaz added a commit that referenced this issue Jun 30, 2020
@viliambalaz
#280 Add review suggestions
45486a0
viliambalaz added a commit that referenced this issue Jun 30, 2020
@viliambalaz
#280 Edit on
be94534
viliambalaz added a commit that referenced this issue Jun 30, 2020
@viliambalaz
#280 Edit on: push
2e0c60d
viliambalaz added a commit that referenced this issue Jul 1, 2020
@viliambalaz
#280 Remove strategy matrix
6cf9a48
@martinmacko47
Copy link
Owner Author

martinmacko47 commented Jul 2, 2020 •
edited
Loading

@viliambalaz Doplnil som do tasku zoznam testov, kde mame skip. Nech mame prehlad, kolko z toho je uz fixnute.

Btw, preco sme premenovali poleno/utils/test.py na poleno/utils/skip_test.py? Ved to nie su testy, ale utility k testom. Potom jasne, ze ti nefungovali importy v testoch, ked si premenoval importovany modul. Pls najprv, predtym nez budes fixovat ostatne testy, premenuj ten modul naspat a odznac skip_ prefixom moduly, ktorym uz importy potom budu fungovat.

Edit: ✔️

viliambalaz added a commit that referenced this issue Jul 2, 2020
@viliambalaz
#280 Add main.yml (#287)
7dc315b 
* #280 Add main.yml

* #280 Edit main.yml

* #280 Use raw_input instead getpass.getpass

* #280 Install requirements for unittesting

* #280 Install requirements for unittesting

* #280 Add review suggestions

* #280 Edit on

* #280 Edit on: push

* #280 Remove strategy matrix
viliambalaz added a commit that referenced this issue Jul 6, 2020
@viliambalaz
#280 Correct import and skip tests
6c0d5c9
viliambalaz added a commit that referenced this issue Jul 8, 2020
@viliambalaz
#280 Correct import and skip tests (#292)
babdf45
viliambalaz added a commit that referenced this issue Aug 10, 2020
@viliambalaz
#280 Fix poleno/utils/tests
d7c76fa
viliambalaz added a commit that referenced this issue Aug 11, 2020
@viliambalaz
#280 Fix poleno/attachments/tests
7b89090
viliambalaz added a commit that referenced this issue Aug 16, 2020
@viliambalaz
#280 Add review suggestions
aa028f0
viliambalaz added a commit that referenced this issue Jul 14, 2021
@viliambalaz
#280 Fix ApplicantDeadlineReminderCronJobTest and CloseInforequestsCr…
6e63968 
…onJobTest tests
viliambalaz added a commit that referenced this issue Jul 14, 2021
@viliambalaz
#280 Fix ApplicantDeadlineReminderCronJobTest and CloseInforequestsCr…
d326d0e 
…onJobTest tests
viliambalaz added a commit that referenced this issue Jul 15, 2021
@viliambalaz
#280 Remove unused import
21c336f
viliambalaz added a commit that referenced this issue Jul 24, 2021
@viliambalaz
#280 Create reload_for_context
b37d73a
martinmacko47 added a commit that referenced this issue Jul 29, 2021
@martinmacko47
#280 Review
94e9e72
martinmacko47 added a commit that referenced this issue Jul 29, 2021
@viliambalaz @martinmacko47
#280 Fix ApplicantDeadlineReminderCronJobTest and CloseInforequestsCr… (
f22ea51 
#415)

* #280 Fix ApplicantDeadlineReminderCronJobTest and CloseInforequestsCronJobTest tests

* #280 Remove unused import

* #280 Create reload_for_context

* #280 Review

Co-authored-by: Martin Macko <[email protected]>
viliambalaz added a commit that referenced this issue Aug 23, 2021
@viliambalaz
#280 Fix inforequests view mine
f016cc3
viliambalaz added a commit that referenced this issue Oct 1, 2021
@viliambalaz
#280 Set correct path to mocked render and render_to_string
fa3606f
viliambalaz added a commit that referenced this issue Oct 30, 2021
@viliambalaz
#280 Add review suggestions
cf88a97
viliambalaz added a commit that referenced this issue Nov 16, 2021
@viliambalaz
#280 Set global password_hasher
c1ee27a
viliambalaz added a commit that referenced this issue Nov 23, 2021
@viliambalaz
#280 Fix inforequests view mine
c926fb6
viliambalaz added a commit that referenced this issue Nov 23, 2021
@viliambalaz
#280 Set correct path to mocked render and render_to_string
525eea5
viliambalaz added a commit that referenced this issue Nov 23, 2021
@viliambalaz
#280 Add review suggestions
1e772bf
viliambalaz added a commit that referenced this issue Nov 23, 2021
@viliambalaz
#280 Set global password_hasher
c56d2bf
viliambalaz added a commit that referenced this issue Nov 23, 2021
@viliambalaz
#280 Use assertTrue instead raising exception
d07cb6f
viliambalaz added a commit that referenced this issue Nov 28, 2021
@viliambalaz
#280 Fix inforequests view mine (#416)
5f4315e 
* #280 Fix inforequests view mine

* #280 Set correct path to mocked render and render_to_string

* #280 Add review suggestions

* #280 Set global password_hasher

* #280 Use assertTrue instead raising exception
viliambalaz added a commit that referenced this issue Dec 15, 2021
@viliambalaz
#280 Fix test_detail view
63976ae
viliambalaz added a commit that referenced this issue Jan 4, 2022
@viliambalaz
#280 Add inforequest test_detail tests
937665e
viliambalaz added a commit that referenced this issue Jan 9, 2022
@viliambalaz
#280 Refactroring tests names
c4922ce
viliambalaz added a commit that referenced this issue Apr 6, 2022
@viliambalaz
#280 Fix test_detail view (#423)
0228618 
* #280 Fix test_detail view

* #280 Add inforequest test_detail tests

* #280 Refactroring tests names
viliambalaz added a commit that referenced this issue Apr 12, 2022
@viliambalaz
#280 Fix test_detail view (#423)
ce9f9f2 
* #280 Fix test_detail view

* #280 Add inforequest test_detail tests

* #280 Refactroring tests names
viliambalaz added a commit that referenced this issue Apr 20, 2022
@viliambalaz
#280 Fix test_create view
a9ca5e6
viliambalaz added a commit that referenced this issue Apr 20, 2022
@viliambalaz
#280 Fix test_create view
dcc30c9
viliambalaz added a commit that referenced this issue Apr 21, 2022
@viliambalaz
#280 Fix DownloadAttachmentViewTest
7013507
viliambalaz added a commit that referenced this issue Apr 25, 2022
@viliambalaz
#280 Compare attachment content
b1c19e1
viliambalaz added a commit that referenced this issue Apr 25, 2022
@viliambalaz
#280 Fix test_create view (#427)
5f3fdbf 
* #280 Fix test_create view

* #280 Compare attachment content
viliambalaz added a commit that referenced this issue Apr 27, 2022
@viliambalaz
#280 Fix DownloadAttachmentViewTest
fd1704c
viliambalaz added a commit that referenced this issue Apr 27, 2022
@viliambalaz
#280 Add tests for anonymous user to download attachment
d85f9b2
viliambalaz added a commit that referenced this issue May 25, 2022
@viliambalaz
#280 Add tests for attachments assigned to action of anonymized infor…
c76b8e8 
…equest
viliambalaz added a commit that referenced this issue May 31, 2022
@viliambalaz
#280 Fix DownloadAttachmentViewTest (#428)
945cb89 
* #280 Fix DownloadAttachmentViewTest

* #280 Add tests for anonymous user to download attachment

* #280 Add tests for attachments assigned to action of anonymized inforequest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viliambalaz viliambalaz

Labels
issue: task part: tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martinmacko47 @viliambalaz