Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marp-cli does not seem to find chromium #475

Open
lu-zero opened this issue Sep 9, 2022 · 2 comments
Open

marp-cli does not seem to find chromium #475

lu-zero opened this issue Sep 9, 2022 · 2 comments
Labels
upstream Caused in upstream, not in this repo

Comments

@lu-zero
Copy link

lu-zero commented Sep 9, 2022

Version of Marp Tool

v2.1.2

Operating System

macOS

Environment

  • OS version: macOS 12.5.1
  • Node.js version: v18.8.0
  • chromium installed via homebrew

How to reproduce

  1. brew install chromium marp-cli
  2. echo '# hi' > /tmp/presentation.md
  3. marp -p /tmp/presentation.md

Expected behavior

having the preview opened in chromium

Actual behavior

[  INFO ] [Preview] Opening file:///tmp/presentation.html...
[ ERROR ] You have to install Google Chrome, Chromium, or Microsoft Edge to convert slide deck with current options.

Additional information

No response

@lu-zero lu-zero added the bug Something isn't working label Sep 9, 2022
@yhatt
Copy link
Member

yhatt commented Sep 9, 2022

https://github.com/GoogleChrome/chrome-launcher/blob/master/src/chrome-finder.ts
chrome-launcher module provided by Google Chrome seems to support finding Chromium binary, only on Linux.

@lu-zero
Copy link
Author

lu-zero commented Sep 9, 2022

export CHROME_PATH="/Applications/Chromium.app/Contents/MacOS/Chromium"

seems a satifying workaround, in case upstream is slow at addressing it.

Thank you a lot for the quick reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Caused in upstream, not in this repo
Projects
None yet
Development

No branches or pull requests

2 participants