Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting scrollable={true} in TabbedFormTabs component throws an error #5695

Closed
WiXSL opened this issue Dec 21, 2020 · 4 comments
Closed

Setting scrollable={true} in TabbedFormTabs component throws an error #5695

WiXSL opened this issue Dec 21, 2020 · 4 comments
Labels
bug documentation v3

Comments

@WiXSL
Copy link
Contributor

WiXSL commented Dec 21, 2020

Using this example from the docs and getting an error:
https://marmelab.com/react-admin/CreateEdit.html#tabbedformtabs

Sandbox:
https://codesandbox.io/s/xenodochial-torvalds-fsbet?file=/src/posts/PostEdit.js

1.- Edit a Post

screenshot
@fzaninotto
Copy link
Member

Right, it seems scrollable was a material-ui v3 prop. The correct prop in v4 is scrollButtons, as explained in the material-ui documentation.

I'm marking this as a documentation issue ; PR welcome!

@Likhitha016 Likhitha016 mentioned this issue Dec 22, 2020
Closed
@WiXSL
Copy link
Contributor Author

WiXSL commented Dec 22, 2020 •
edited

I tried setting tabs={<TabbedFormTabs variant="scrollable" scrollButtons="auto" />} to TabbedForm component but it doesn't show a vertical scrollbar.

@fzaninotto
Copy link
Member

#5713 seems to fix that problem but I don't understand why.

@WiXSL WiXSL mentioned this issue Feb 26, 2021
Merged
@WiXSL WiXSL added the v3 label Oct 15, 2022
@fzaninotto
Copy link
Member

Fixed by #5960

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug documentation v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix error thrown when scrollable is set {true} Likhitha016/react-admin
2 participants
@fzaninotto @WiXSL