-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable suggestion scrolling without setting a hard limit #714
Labels
enhancement
New feature or request
Comments
I think there are actually two separate suggestions or at least two steps to this suggestion:
From my perspective, I would love to have 1, while 2 is not such a big deal as a very large limit can just be used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What do you want?
An option to scroll choose a default number of history-lines and scroll to previous history-lines instead of circling back to the first one.
Why do you want this?
When using small terminals (for example - embedded terminal in VSCode) the number of history-lines is too small. If I see 5 history-lines, there is no scrolling back to suggestion 6. The only way to go around that is to manually set the number of lines to be something bigger. Let's say for the sake of argument that 20 is a fair number.
Now if a bigger number like 20 is set, when using the same terminal on a bigger screen the history-lines take up the entire screen and you can see the output of the previous command as the command you're typing goes to the top of the screen.
Who else would benefit from this?
Everyone who uses different terminal sizes on the same machine. This is common when opening a stand-alone terminal and a minified terminal in another program (like code editors).
How should it work?
I see two options:
Given the following situation:
When the appropriate config is set
When I perform the following steps:
When scrolling with the up arrow past the last suggestion shown
Then I expect the following to happen:
I'll see more history-lines
The text was updated successfully, but these errors were encountered: