{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":656735844,"defaultBranch":"develop","name":"bottlerocket-sdk","ownerLogin":"markusboehme","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-06-21T14:29:07.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/5074759?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1704481003.0","currentOid":""},"activityList":{"items":[{"before":"b1954df40125e44f4b3689f487190f848b664af5","after":"f34c78660668eb6c4de5dc7f558213809b8280c4","ref":"refs/heads/fix/with-go-env","pushedAt":"2024-01-05T18:59:02.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"markusboehme","name":"Markus Boehme","path":"/markusboehme","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5074759?s=80&v=4"},"commit":{"message":"include go.env file at GOROOT expected by Go 1.21 and above\n\nGo 1.21 moved the definition of defaults of some `GO*` environment\nvariables from source to a `go.env` configuration file [1]. Make sure to\ninclude that file in the final image, otherwise some variables like\n`GOPROXY` will have no value if not explicitly specified by the user,\nand builds using the SDK could fail.\n\nNote this is not introducing opinionated new defaults, but rather just\naccommodating a change in the upstream Go release. Values for these\nvariables explicitly specified by the user still take precedence.\n\n[1]: https://github.com/golang/go/commit/7aa85e01376d840acc8bb931156d607a00b64a60\n\nSigned-off-by: Markus Boehme <markubo@amazon.com>","shortMessageHtmlLink":"include go.env file at GOROOT expected by Go 1.21 and above"}},{"before":null,"after":"b1954df40125e44f4b3689f487190f848b664af5","ref":"refs/heads/fix/with-go-env","pushedAt":"2024-01-05T18:56:43.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"markusboehme","name":"Markus Boehme","path":"/markusboehme","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5074759?s=80&v=4"},"commit":{"message":"include go.env file at GOROOT expected by Go 1.21 and above\n\nGo 1.21 moved the definition of defaults of some `GO*` environment\nvariables from source to a `go.env` configuration file [1]. Make sure\nthe build actually includes that file in the final image, otherwise some\nvariables like `GOPROXY` will have no value if not explicitly specified\nby the user, and builds using the SDK could fail.\n\n[1]: https://github.com/golang/go/commit/7aa85e01376d840acc8bb931156d607a00b64a60\n\nSigned-off-by: Markus Boehme <markubo@amazon.com>","shortMessageHtmlLink":"include go.env file at GOROOT expected by Go 1.21 and above"}},{"before":null,"after":"bedf369971129542e062dea0bac153e13f9c6eea","ref":"refs/heads/with-protobuf","pushedAt":"2023-10-04T17:11:48.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"markusboehme","name":"Markus Boehme","path":"/markusboehme","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5074759?s=80&v=4"},"commit":{"message":"add protobuf-compiler and protobuf-devel\n\nSigned-off-by: Markus Boehme <markubo@amazon.com>","shortMessageHtmlLink":"add protobuf-compiler and protobuf-devel"}},{"before":"00a68da1dd8eeeb78db738e3e22001e2eca57562","after":"f348e1f78f4fbc3f36c55dbf2dd4b340c6370cfa","ref":"refs/heads/feature/with-libstdc++-so","pushedAt":"2023-09-05T11:35:25.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"markusboehme","name":"Markus Boehme","path":"/markusboehme","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5074759?s=80&v=4"},"commit":{"message":"buildroot: build libstdc++ as shared object\n\nBuild libstdc++ as a shared object, too. The archive file for static\nlinking cannot be used to produce shared objects out of code written in\nC++ since its code is not position-independent (PIC).\n\nSigned-off-by: Markus Boehme <markubo@amazon.com>","shortMessageHtmlLink":"buildroot: build libstdc++ as shared object"}},{"before":null,"after":"00a68da1dd8eeeb78db738e3e22001e2eca57562","ref":"refs/heads/feature/with-libstdc++-so","pushedAt":"2023-08-18T17:40:37.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"markusboehme","name":"Markus Boehme","path":"/markusboehme","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5074759?s=80&v=4"},"commit":{"message":"buildroot: build libstdc++ as shared object\n\nBuild libstdc++ as a shared object, too. The archive file for static\nlinking cannot be used to produce shared objects out of code written in\nC++ since its code is not position-independent (PIC).\n\nSigned-off-by: Markus Boehme <markubo@amazon.com>","shortMessageHtmlLink":"buildroot: build libstdc++ as shared object"}},{"before":null,"after":"576767e46086504eef2e07e769b4792450617c83","ref":"refs/heads/improvement/force-disable-rpath","pushedAt":"2023-08-01T15:59:56.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"markusboehme","name":"Markus Boehme","path":"/markusboehme","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5074759?s=80&v=4"},"commit":{"message":"macros: add force_disable_rpath macro to centralize libtool hack\n\nVarious third-party packages utilizing libtool don't provide an option\nin their `configure` script to disable embedding an rpath into ELF files\nduring linking. The spec files of those packages make use of a libtool\nhack that dates back to 2006 [1]. Move that into a shared macro so it\ncan be easily reused instead of duplicated.\n\n[1]: https://listman.redhat.com/archives/fedora-extras-list/2006-October/029255.html\n\nSigned-off-by: Markus Boehme <markubo@amazon.com>","shortMessageHtmlLink":"macros: add force_disable_rpath macro to centralize libtool hack"}},{"before":null,"after":"576767e46086504eef2e07e769b4792450617c83","ref":"refs/heads/imp/force-disable-rpath","pushedAt":"2023-07-24T21:53:45.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"markusboehme","name":"Markus Boehme","path":"/markusboehme","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5074759?s=80&v=4"},"commit":{"message":"macros: add force_disable_rpath macro to centralize libtool hack\n\nVarious third-party packages utilizing libtool don't provide an option\nin their `configure` script to disable embedding an rpath into ELF files\nduring linking. The spec files of those packages make use of a libtool\nhack that dates back to 2006 [1]. Move that into a shared macro so it\ncan be easily reused instead of duplicated.\n\n[1]: https://listman.redhat.com/archives/fedora-extras-list/2006-October/029255.html\n\nSigned-off-by: Markus Boehme <markubo@amazon.com>","shortMessageHtmlLink":"macros: add force_disable_rpath macro to centralize libtool hack"}},{"before":null,"after":"e4f96ffdca1e1e667d62a97fa48a194e8e9b7c4e","ref":"refs/heads/fix/publish-sdk-with-region","pushedAt":"2023-07-21T11:06:11.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"markusboehme","name":"Markus Boehme","path":"/markusboehme","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5074759?s=80&v=4"},"commit":{"message":"publish-sdk: explicitly pass repository region for manifest removal\n\nThe removal step before manifest (re)creation relied on the AWS CLI\nusing its configured default region. This fails when none is configured.\nDerive the region to operate in from the given repository.\n\nSigned-off-by: Markus Boehme <markubo@amazon.com>","shortMessageHtmlLink":"publish-sdk: explicitly pass repository region for manifest removal"}},{"before":null,"after":"e226930a50b8bcaacade2374e375a3c2c2399352","ref":"refs/heads/feat/with-libstdc++-so","pushedAt":"2023-07-20T16:51:35.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"markusboehme","name":"Markus Boehme","path":"/markusboehme","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5074759?s=80&v=4"},"commit":{"message":"buildroot: build libstdc++ as shared object\n\nBuild libstdc++ as a shared object, too. The archive file for static\nlinking cannot be used to produce shared objects out of code written in\nC++ since its code is not position-independent (PIC).\n\nSigned-off-by: Markus Boehme <markubo@amazon.com>","shortMessageHtmlLink":"buildroot: build libstdc++ as shared object"}},{"before":"d6244ff22cd4bc722b523cbef5a459aa6ed1eff8","after":"bad9ac6361d9d9970f4de683735318b5e7862a7f","ref":"refs/heads/fix/prevent-redefining-fortify-source","pushedAt":"2023-06-21T14:35:51.189Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"markusboehme","name":"Markus Boehme","path":"/markusboehme","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5074759?s=80&v=4"},"commit":{"message":"macros: prevent redefining _FORTIFY_SOURCE\n\nEnsure `_FORTIFY_SOURCE` is unset before setting it to the intended\nvalue. This prevents warnings or errors (if `-Werror` is used) in case a\nthird-party package's build system also overrides `_FORTIFY_SOURCE`:\n\n    <command-line>: error: \"_FORTIFY_SOURCE\" redefined [-Werror]\n    <command-line>: note: this is the location of the previous definition\n\nIn this particular case, a package's build system needed to explicitly\nopt out of fortification for part of its code, adding the following to\nits `CFLAGS`:\n\n    -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -Wp,-U_FORTIFY_SOURCE -Wp,-D_FORTIFY_SOURCE=0\n\nWith the existing definition of `_FORTIFY_SOURCE=2` via Bottlerocket's\nRPM macros, this turns into a `gcc` invocation simplified to:\n\n    -Wp,-D_FORTIFY_SOURCE=2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -Wp,-U_FORTIFY_SOURCE -Wp,-D_FORTIFY_SOURCE=0\n\nWhen the `gcc` compiler driver actually invokes the compiler, the\narguments have been reordered: General macro definitions (`-D`, `-U`)\ncome first, followed by options passed through to the preprocessor\n(`-Wp`). The reordering results in the following order of arguments to\nthe compiler:\n\n    -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -D_FORTIFY_SOURCE=2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0\n                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n\nThis now redefines `_FORTIFY_SOURCE` with a conflicting value. We can\nprevent that by always undefining a macro first, making undefine/define\noperations always show up pairwise in the resulting command line.\n\nSigned-off-by: Markus Boehme <markubo@amazon.com>","shortMessageHtmlLink":"macros: prevent redefining _FORTIFY_SOURCE"}},{"before":null,"after":"d6244ff22cd4bc722b523cbef5a459aa6ed1eff8","ref":"refs/heads/fix/prevent-redefining-fortify-source","pushedAt":"2023-06-21T14:29:53.874Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"markusboehme","name":"Markus Boehme","path":"/markusboehme","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5074759?s=80&v=4"},"commit":{"message":"macros: prevent redefining _FORTIFY_SOURCE\n\nEnsure `_FORTIFY_SOURCE` is unset before setting it to the intended\nvalue. This prevents warnings or errors (if `-Werror` is used) in case a\nthird-party package's build system also overrides `_FORTIFY_SOURCE`:\n\n    <command-line>: error: \"_FORTIFY_SOURCE\" redefined [-Werror]\n    <command-line>: note: this is the location of the previous definition\n\nIn this particular case, a package's build system needed to explicitly\nopt out of fortification for part of its code, adding the following to\nits `CFLAGS`:\n\n   -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -Wp,-U_FORTIFY_SOURCE -Wp,-D_FORTIFY_SOURCE=0\n\nWith the existing definition of `_FORTIFY_SOURCE=2` via Bottlerocket's\nRPM macros, this turns into a `gcc` invocation simplified to:\n\n   -Wp,-D_FORTIFY_SOURCE=2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -Wp,-U_FORTIFY_SOURCE -Wp,-D_FORTIFY_SOURCE=0\n\nWhen the `gcc` compiler driver actually invokes the compiler, the\narguments have been reordered: General macro definitions (`-D`, `-U`)\ncome first, followed by options passed through to the preprocessor\n(`-Wp`). The reordering results in the following order of arguments to\nthe compiler:\n\n   -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -D_FORTIFY_SOURCE=2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0\n                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n\nThis now redefines `_FORTIFY_SOURCE` with a conflicting value. We can\nprevent that by always undefining a macro first, making undefine/define\noperations always show up pairwise in the resulting command line.\n\nSigned-off-by: Markus Boehme <markubo@amazon.com>","shortMessageHtmlLink":"macros: prevent redefining _FORTIFY_SOURCE"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAD2NPR6wA","startCursor":null,"endCursor":null}},"title":"Activity · markusboehme/bottlerocket-sdk"}