Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure when uploading clipboard images with PicGo #3360

Open
Jakentop opened this issue Jul 21, 2022 · 10 comments · May be fixed by #3366
Open

Failure when uploading clipboard images with PicGo #3360

Jakentop opened this issue Jul 21, 2022 · 10 comments · May be fixed by #3366

Comments

@Jakentop
Copy link

Description

Uploading clipboard images with PicGo fails, but if local images are uploaded via PicGo, it works

Steps to reproduce

image
When I paste an image directly from the clipboard, it stays in the Loading state
image
PicGo is configured without problems

Versions

  • MarkText version: v0.17.1
  • PicGo: 1.5.0-alpha.0
  • Operating system: windows 10
@Jakentop
Copy link
Author

image
In DevTools I found the following exception

@chinayangxiaowei
Copy link

chinayangxiaowei commented Jul 22, 2022

You can refer to this question #3118

@Jakentop
Copy link
Author

I found someone else had the same problem as me in #2915,I referenced his PR with #3296 but it doesn't work。I found that he reads the path information of the clipboard file, but after debug I found that in some cases (images saved in the clipboard using the screenshot tool) he has an empty path field. So one solution could be to use the MIME-TYPE in the clipboard to determine this. But I didn't want to bother with that, so I just added a fixed suffix to the filepath, and I actually found that it worked.

@CarryWll
Copy link

CarryWll commented Aug 4, 2022

The current installed version v0.17.1 still has this problem. Will it be fixed in the next version?

@Jakentop
Copy link
Author

Jakentop commented Aug 5, 2022

The current installed version v0.17.1 still has this problem. Will it be fixed in the next version?
You can find this PR, just modify a line of code to temporarily solve the problem, the specific can wait for the author to fix. #3366
You can also refer to this author's PR, #3296. I found this fix to be ineffective in my scenario for the reasons I explained above.

@beierzhijin
Copy link

beierzhijin commented Sep 22, 2022

The current installed version v0.17.1 still has this problem. Will it be fixed in the next version?
You can find this PR, just modify a line of code to temporarily solve the problem, the specific can wait for the author to fix. #3366
You can also refer to this author's PR, #3296. I found this fix to be ineffective in my scenario for the reasons I explained above.

I want to use this fixed version, do I need to build by myself ?
我要用这个修复的pr,作者还没发修复版,我是不是要自己打包,有什么好的方法的吗,新手求教

@Jakentop
Copy link
Author

The current installed version v0.17.1 still has this problem. Will it be fixed in the next version?
You can find this PR, just modify a line of code to temporarily solve the problem, the specific can wait for the author to fix. #3366
You can also refer to this author's PR, #3296. I found this fix to be ineffective in my scenario for the reasons I explained above.

I want to use this fixed version, do I need to build by myself ? 我要用这个修复的pr,作者还没发修复版,我是不是要自己打包,有什么好的方法的吗,新手求教

可以直接自己打包,其实就改了一行代码。

@beierzhijin
Copy link

I have rebuilt the fixed version from @Jakentop-fix Failure when uploading clipboard images with PicGo #3360. 栓Q@Jakentop.
download from my fork: https://github.com/beierzhijin/marktext/releases/tag/v0.17.1

@kyuuketsu
Copy link

I have rebuilt the fixed version from @Jakentop-fix Failure when uploading clipboard images with PicGo #3360. 栓Q@Jakentop. download from my fork: https://github.com/beierzhijin/marktext/releases/tag/v0.17.1

感谢,替换原文件后终于可以正常使用图片粘贴功能了。

@maxchiron
Copy link

I have rebuilt the fixed version from @Jakentop-fix Failure when uploading clipboard images with PicGo #3360. 栓Q@Jakentop. download from my fork: https://github.com/beierzhijin/marktext/releases/tag/v0.17.1

You are a life saver, true LeiFeng, real man. God bless you. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants