Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address issue #59 - CWS_WP_Help_Plugin::api_slurp() #60

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Address issue #59 - CWS_WP_Help_Plugin::api_slurp() #60

wants to merge 3 commits into from

Conversation

jibbius
Copy link

@jibbius jibbius commented Sep 17, 2020 •
edited
Loading

Resolves #59

@jibbius jibbius mentioned this pull request Sep 17, 2020
Open
@jibbius
Copy link
Author

jibbius commented Oct 15, 2020

(Updated, to remove branch conflicts).

@jibbius
Copy link
Author

jibbius commented Oct 15, 2020

Short version of the issue:

  • CWS_WP_Help_Plugin::api_slurp() doesn't register the wp-help post type.
  • CWS_WP_Help_Plugin::api_slurp() is capable of calling wp_update_post(), however.
  • Other plugins attach themselves to this hook (and/or) wp_insert_post... and can reasonably expect the post type to be registered.
  • Thus, this causes an error/warning in some cases.
  • The error/warning gets thrown in the other plugin... but ultimately the issue is in wp-help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CWS_WP_Help_Plugin::api_slurp() never registers the wp-help post type
1 participant
@jibbius