Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing var declaration for toggleCopyButton function #20

Open
francoismajor opened this issue Jul 8, 2020 · 3 comments
Open

Missing var declaration for toggleCopyButton function #20

francoismajor opened this issue Jul 8, 2020 · 3 comments

Comments

@francoismajor
Copy link

francoismajor commented Jul 8, 2020

This returns an error. (button is not defined) The function still works, but 'Copied!' text is not displayed.

button = document.getElementById(app.prefix('-button-copy'));

buttonText = document.getElementById(app.prefix('-button-text-copy'));

Simple fix:
var button = document.getElementById(t.prefix('-button-copy'));
var buttonText = document.getElementById(t.prefix('-button-text-copy'));

janogarcia added a commit to janogarcia/mailtoui that referenced this issue Aug 18, 2020
@janogarcia
Copy link

Just ran into the same issue today, when executing mailtoui under strict mode.

Fixed it here. Let me know if you want me to submit a pull request. 👍

@mariordev
Copy link
Owner

Hi @janogarcia,
Thank you for letting me know. No need to submit a pr, I'll get this fix in as soon as I can. Thanks!

@mariordev
Copy link
Owner

Hi @francoismajor, thanks for pointing this out! I'll get this fix in as soon as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants