Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify all instances of development URL #13

Open
wcrum opened this issue Sep 27, 2022 · 1 comment
Open

Modify all instances of development URL #13

wcrum opened this issue Sep 27, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@wcrum
Copy link
Member

wcrum commented Sep 27, 2022

Several files including the mkdocs.yml have linked to v2.marines.dev this is simply for correct asset mapping. Prior to relasing we need to change this an the CNAME.

@wcrum wcrum self-assigned this Sep 27, 2022
@wcrum wcrum added the bug Something isn't working label Oct 31, 2022
@wcrum
Copy link
Member Author

wcrum commented Nov 3, 2022

site_url: https://v2.marines.dev/

v2.marines.dev

v2.marines.dev

I am kinda of sure the reason that CNAME exists within / and /docs is because the CNAME file wasnt moving over into the gh-pages branch unless it gets caked in after the actions, specifically after mkdocs gh-deploy --force. Might delete root CNAME but 🤷🏻.

Most people look at root CNAME anyway, could just move it during action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant