Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync timestamp should increase to microsecond precision #103

Open
marcus-crane opened this issue Dec 6, 2023 · 2 comments
Open

Sync timestamp should increase to microsecond precision #103

marcus-crane opened this issue Dec 6, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@marcus-crane
Copy link
Owner

marcus-crane commented Dec 6, 2023 •
edited

Something I noticed while reviewing my own highlights in Obsidian is that timestamps for highlights from Readwise Reader contain 6 decimal places of precision (microseconds) whereas we just submit regular second timestamps with October.

Functionally, this makes no difference but visually makes for nice consistency and technically it's possible to have ordering weirdness if different books were uploaded within the same second which is probably rate but not impossible.

CleanShot 2023-12-06 at 13 37 49
@marcus-crane marcus-crane added the enhancement New feature or request label Dec 6, 2023
@marcus-crane marcus-crane changed the title Sync timestamp should have increased granularity Sync timestamp should increase to microsecond precision Dec 6, 2023
@marcus-crane
Copy link
Owner Author

As best as I can tell, Reader's timestamp changed sometime in 2021 which would be sometime after the very first version of October was released (has it really been more than 2 years?!)

@marcus-crane
Copy link
Owner Author

Highlights have 3 decimal places of precision but we can still format the last 3 places as 0's for consistency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marcus-crane