Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github action doesn't set correct Minecraft versions. #78

Open
Chaos02 opened this issue Aug 14, 2022 · 3 comments
Open

Github action doesn't set correct Minecraft versions. #78

Chaos02 opened this issue Aug 14, 2022 · 3 comments

Comments

@Chaos02
Copy link

Chaos02 commented Aug 14, 2022

I have just investigated why CF always sets the latest minecraft version for uploaded files.
The Culprit is that the CF uploader (https://github.com/itsmeow/curseforge-upload@v3) is being run with
the game-versions of Minecraft <extracted manifest version here>.

This is a problem since the field should contain IDs for game versions that can be extracted through the API and a slug/name consisting of the extracted manifest version.
Documentation here: CurseForge

If you would like me to implement this feature, please reach out.
It requries the same token in the GET-request as the upload.

@Chaos02
Copy link
Author

Chaos02 commented Aug 14, 2022

it could btw also add a version for the major version of minecraft aswell as the forge/fabric version being used (or just forge and fabric accordingly)

@Chaos02
Copy link
Author

Chaos02 commented Aug 15, 2022

correction: the correct minecraft and forge VersionID can be obtained here:
https://api.curseforge.com/v1/minecraft/version/1.18.2
https://api.curseforge.com/v1/minecraft/modloader/forge-40.1.73

@warezit
Copy link

warezit commented Sep 12, 2023

I'm having this issue also.

Manifest says 1.19.2. When I check CurseForge it says 1.20.2-Snapshot (since that is the most current release of MC right now). Link to my setup/repo here

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants