Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rowHeightPx is ignored #83

Closed
creffect opened this issue Feb 19, 2024 · 3 comments · May be fixed by #85
Closed

rowHeightPx is ignored #83

creffect opened this issue Feb 19, 2024 · 3 comments · May be fixed by #85
Labels
enhancement New feature or request no-issue-activity

Comments

@creffect
Copy link

Describe the bug
The option "rowHeightPx" is ignored. It seems, that ROW_HEIGHT in the source code is always a constant and not changeable from 22px. (export const ROW_HEIGHT = 22 in common.ts)

To Reproduce
Steps to reproduce the behavior:
const tree = new Wunderbaum({ element: this.treeElement.nativeElement, source: [{title: "Test"}], rowHeightPx: 40 });
Expected behavior
Row height is adjustable (for usability reasons).

Thank you for checking!
@creffect creffect added bug Something isn't working need-triage labels Feb 19, 2024
@elevenlabsdev
Copy link

Hello, to add to this: Would it also be possible to make the row height dynamic, e.g. depending on the row content?

Many thanks!

@mar10 mar10 mentioned this issue Feb 29, 2024
Open
@mar10 mar10 added enhancement New feature or request and removed bug Something isn't working need-triage labels Feb 29, 2024
@mar10
Copy link
Owner

mar10 commented Feb 29, 2024

Hello, to add to this: Would it also be possible to make the row height dynamic, e.g. depending on the row content?

Many thanks!

This would be way more complicated, since then we cannot define simple CSS rules for rows or calculate viewport sizes by simple multiplication. This should be discussed in a separate thread.

@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request no-issue-activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Honor rowHeightPx option mar10/wunderbaum
3 participants
@mar10 @creffect @elevenlabsdev