Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UNSAFE_componentWillReceiveProps #50

Closed
wmonecke opened this issue Jul 26, 2023 · 3 comments
Closed

UNSAFE_componentWillReceiveProps #50

wmonecke opened this issue Jul 26, 2023 · 3 comments
Labels
enhancement New feature or request
Milestone
10.0.0

Comments

@wmonecke
Copy link

The current version

"@maplibre/maplibre-react-native": "^9.0.1"

still uses a deprecated method. We should move to function components.

It is being used in /javascript/components/MapView.js, line 317.
@sarahsporck
Copy link
Collaborator

Are you open to creating a PR for this. (No need to refactor the whole repo. Just this component for now :) )

@wmonecke
Copy link
Author

wmonecke commented Oct 4, 2023

Hey @sarahsporck Ill give it a shot! :)

@WingmanImd WingmanImd mentioned this issue Feb 7, 2024
Closed
7 tasks
@KiwiKilian
Copy link
Collaborator

This was completed is available on the current v10 pre-releases.

@KiwiKilian KiwiKilian added this to the 10.0.0 milestone Nov 15, 2024
@KiwiKilian KiwiKilian added the enhancement New feature or request label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

Migrate MapView to react function components WingmanImd/maplibre-react-native
3 participants
@KiwiKilian @wmonecke @sarahsporck