Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F-Droid Compatibility #433

Open
meypod opened this issue Aug 19, 2024 · 7 comments
Open

F-Droid Compatibility #433

meypod opened this issue Aug 19, 2024 · 7 comments

Comments

@meypod
Copy link

meypod commented Aug 19, 2024

Hi

Since Maplibre is using https://dl.bintray.com/maplibre/maplibre-gl-native maven repo, f-droid builds are failing. I think the library should be hosted on a well-known maven repo.

related: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/15592

thank you for your hard work

@tyrauber
Copy link
Collaborator

I don't even see the Android documentation adding this line?! A search for bintray.com comes up empty. I wonder if this is a legacy requirement of older versions of the SDK. Perhaps the newer SDK doesn't require it and just removing this line will work?

@meypod
Copy link
Author

meypod commented Aug 20, 2024

hi
it's because it's here, in maplibre-react-native:

url = "https://dl.bintray.com/maplibre/maplibre-gl-native"

@meypod
Copy link
Author

meypod commented Aug 25, 2024

@tyrauber I seem to be able to build it locally with the maven block removed, and the build works, so I guess it's a legacy requirement of maplibre-react-native ?

sorry about the mention.

@tyrauber
Copy link
Collaborator

No worries! The native SDKs have been updated significantly since the 9.0 SDKs. My guess it is probably can be removed, I just haven't got to testing it myself.

@birkskyum
Copy link
Member

birkskyum commented Oct 28, 2024

The latest MapLibre Native is compatible F-Droid since Android SDK v10:

@meypod
Copy link
Author

meypod commented Oct 28, 2024

As far as i remember you just need to remove the maven block mentioned and it's good to go

@KiwiKilian
Copy link
Collaborator

F-Droid should be usable with the latest v10 prereleases. Can anyone confirm this? How could I check this myself?

Also, which part would be flagged by F-Droid for using Google? Could we use a variable in the build.gradle to optionally add the implementation "com.google.android.gms:play-services-location:21.3.0" line? Or would also the sheer existence of the implementation, which would be conditionally choosen be a problem?

Basically, I would like to have this patch in the package, toggled by a variable or something, allowing this functionality to be toggle by an Expo plugin variable.

@KiwiKilian KiwiKilian changed the title Maplibre is not usable on f-droid F-Droid Compatibility Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants