-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure out Detox and why it's so slow #23
Comments
🤔 @ianthetechie, this appears to be a question rather than an issue |
Oops :D Forgot that action existed.... |
The tests currently only start the example app and check whether components are rendered in the root page. So basically they don't test the actual maplibre functionality atm. What does make sense though that it is building the app (at least for ios) in the CI. |
Fixed by #535 |
🎉 This issue has been resolved in version 10.0.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Local iOS builds are super fast, but the Detox build is super slow and the tests sometimes fail. Tangentially related to #22, we need to understand what's going on here as this was inherited from upstream. Going through their guides (https://wix.github.io/Detox/docs/introduction/project-setup/), I don't see a
.detoxrc.js
, so I'm not sure if we're even using it correctly, nor what the tests actually do at the moment.Also curiously, it claims to be a cross-platform framework, but it's only integrated into the iOS CI actions. If this is providing a real benefit, we should probably get it running on Android as well.
The text was updated successfully, but these errors were encountered: