Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out Detox and why it's so slow #23

Closed
ianthetechie opened this issue Dec 30, 2022 · 5 comments
Closed

Figure out Detox and why it's so slow #23

ianthetechie opened this issue Dec 30, 2022 · 5 comments
Assignees
Labels
help wanted Extra attention is needed released on @beta

Comments

@ianthetechie
Copy link
Collaborator

Local iOS builds are super fast, but the Detox build is super slow and the tests sometimes fail. Tangentially related to #22, we need to understand what's going on here as this was inherited from upstream. Going through their guides (https://wix.github.io/Detox/docs/introduction/project-setup/), I don't see a .detoxrc.js, so I'm not sure if we're even using it correctly, nor what the tests actually do at the moment.

Also curiously, it claims to be a cross-platform framework, but it's only integrated into the iOS CI actions. If this is providing a real benefit, we should probably get it running on Android as well.

@ianthetechie ianthetechie added help wanted Extra attention is needed question Further information is requested labels Dec 30, 2022
@github-actions
Copy link

🤔 @ianthetechie, this appears to be a question rather than an issue
please use GitHub Discussions or Slack.

@ianthetechie ianthetechie removed the question Further information is requested label Dec 30, 2022
@ianthetechie
Copy link
Collaborator Author

Oops :D Forgot that action existed....

@ianthetechie ianthetechie reopened this Dec 30, 2022
@sarahsporck
Copy link
Collaborator

The tests currently only start the example app and check whether components are rendered in the root page. So basically they don't test the actual maplibre functionality atm. What does make sense though that it is building the app (at least for ios) in the CI.
Starting detox v20 the config became a little bit simpler. Check out this PR to see what changed.

@KiwiKilian
Copy link
Collaborator

Fixed by #535

Copy link

github-actions bot commented Dec 8, 2024

🎉 This issue has been resolved in version 10.0.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed released on @beta
Projects
None yet
Development

No branches or pull requests

3 participants