From ff756d7d3e8a4c88cad1143a77a1c0f6877f04f2 Mon Sep 17 00:00:00 2001 From: Kilian Finger Date: Tue, 26 Nov 2024 13:02:54 +0100 Subject: [PATCH] ci: reorder tsc and eslint --- .github/workflows/review.yml | 24 ++++++++++++------------ package.json | 10 +++++----- 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/.github/workflows/review.yml b/.github/workflows/review.yml index fe623027f..645a3b3fb 100644 --- a/.github/workflows/review.yml +++ b/.github/workflows/review.yml @@ -12,8 +12,8 @@ on: - checks_requested jobs: - lint-eslint: - name: Lint ESLint + lint-tsc: + name: Lint TSC runs-on: ubuntu-latest steps: - name: Checkout @@ -22,14 +22,14 @@ jobs: - name: Setup uses: ./.github/actions/setup - - name: Lint with ESLint - run: yarn lint:eslint + - name: Lint with TSC + run: yarn lint:tsc - - name: Lint Plugin with ESLint - run: yarn plugin:lint:eslint + - name: Lint Plugin with TSC + run: yarn plugin:lint:tsc - lint-tsc: - name: Lint TSC + lint-eslint: + name: Lint ESLint runs-on: ubuntu-latest steps: - name: Checkout @@ -38,11 +38,11 @@ jobs: - name: Setup uses: ./.github/actions/setup - - name: Lint with TSC - run: yarn lint:tsc + - name: Lint with ESLint + run: yarn lint:eslint - - name: Lint Plugin with TSC - run: yarn plugin:lint:tsc + - name: Lint Plugin with ESLint + run: yarn plugin:lint:eslint test: name: Test diff --git a/package.json b/package.json index a643ccc55..cc9ec83da 100644 --- a/package.json +++ b/package.json @@ -27,13 +27,13 @@ "codegen": "tsx scripts/codegen.ts", "test": "jest", "lint": "yarn lint:tsc && yarn lint:eslint", - "lint:eslint": "eslint .", - "lint:eslint:fix": "eslint . --fix", - "lint:tsc": "tsc --project . && tsc --project ./packages/examples", + "lint:tsc": "tsc --project ./ && tsc --project ./packages/examples", + "lint:eslint": "eslint ./", + "lint:eslint:fix": "eslint ./ --fix", "plugin:build": "tsc --build ./plugin", - "plugin:lint": "yarn plugin:lint:eslint && yarn plugin:lint:tsc", + "plugin:lint": "yarn plugin:lint:tsc && yarn plugin:lint:eslint", + "plugin:lint:tsc": "tsc --noEmit --project ./plugin", "plugin:lint:eslint": "eslint ./plugin/src/*", - "plugin:lint:tsc": "tsc --project ./plugin --noEmit", "plugin:test": "jest ./plugin", "prepack": "bob build && yarn plugin:build" },