-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect wrapping code #44
Comments
Not a maintainer or contributor, but I've been working with this library a bit lately. My thoughts: This is intended - there is a distinction between jni::Constructor and jni::Method. Constructors require creating a new local reference, while any objects returned from Java via a non-constructor method will already have been created. Use |
The code at
native_method:328 seems incorrect, why would you do std::decay_t&?
Comment mine:
auto wrapper = [field, initializer] (JNIEnv& e, Object& obj, /std::decay_t&/Args... args) // TODO why reference?
This causes wrapping of constructors to fail.
The text was updated successfully, but these errors were encountered: