Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viz app broken on recent OS X #78

Open
springmeyer opened this issue Sep 18, 2019 · 1 comment
Open

Viz app broken on recent OS X #78

springmeyer opened this issue Sep 18, 2019 · 1 comment
Labels

Comments

@springmeyer
Copy link
Contributor

The build currently fails with >= 10.14 due to the combo of deprecation warnings + -Werror:

/Users/travis/build/mapbox/earcut.hpp/test/viz.cpp:67:9: error: 'glViewport' is deprecated: first deprecated in macOS 10.14 - OpenGL API deprecated. (Define GL_SILENCE_DEPRECATION to silence these warnings) [-Werror,-Wdeprecated-declarations]
        glViewport(0, 0, viewWidth, viewHeight);
        ^

https://travis-ci.org/mapbox/earcut.hpp/jobs/586690931#L629

This can be trigged by changing travis to test with xcode_image: 11 instead of osx_image: xcode8

@mrgreywater
Copy link
Collaborator

mrgreywater commented Sep 18, 2019

OSX is dropping support for OpenGL. Nothing we can really do about it, except for adding Metal support (doubt anybody feels inclined to do so).

For now I suggest we define GL_SILENCE_DEPRECATION for OSX and leave it at that.

@mourner mourner added the bug label Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants