Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added section for testing ADS interactions to MSlice manual testing doc #38513

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SilkeSchomann
Copy link
Contributor

@SilkeSchomann SilkeSchomann commented Dec 16, 2024

Description of work

Recently, an ADS observer was added to MSlice. This allows monitoring changes to the ADS and reacting accordingly. This new functionality should be covered by manual tests, so I have updated the manual testing instructions for MSlice.

Fixes #38491.

To test:

Read the new instructions and check grammar and spelling.

For following the test instructions, the MSlice version in Mantid needs to be updated to the latest MSlice nightly version.

This does not require release notes because it is a change of the developer documentation and not user facing.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@SilkeSchomann SilkeSchomann added Documentation Issues and pull requests related to documentation Maintenance Unassigned issues to be addressed in the next maintenance period. ISIS Team: Excitations/Vesuvio Issue and pull requests managed by the Excitiations/Vesuvio subteam at ISIS labels Dec 16, 2024
@SilkeSchomann SilkeSchomann added this to the Release 6.12 milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues and pull requests related to documentation ISIS Team: Excitations/Vesuvio Issue and pull requests managed by the Excitiations/Vesuvio subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
Status: Unassigned
Development

Successfully merging this pull request may close these issues.

Update manual testing instructions for MSlice
1 participant