Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stdout should be io.Writer instead of io.WriterCloser #211

Open
mbalsam82 opened this issue Oct 12, 2022 · 0 comments
Open

Stdout should be io.Writer instead of io.WriterCloser #211

mbalsam82 opened this issue Oct 12, 2022 · 0 comments

Comments

@mbalsam82
Copy link

mbalsam82 commented Oct 12, 2022

As far as I can see, it is only used in the readline.Config which expects io.Writer, not io.WriterCloser (see here). p.Stdout.Close() is never called.

It's a bit inconvenient that when I want to configure an io.Writer as Stdout, I always need to wrap it in a struct that implements an unnecessary, no-op Close() function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant