Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: using npm instead of yarn #12

Open
thanhpd opened this issue Oct 17, 2018 · 1 comment
Open

docs: using npm instead of yarn #12

thanhpd opened this issue Oct 17, 2018 · 1 comment
Labels
good first issue Good for newcomers Hacktoberfest type: refactor

Comments

@thanhpd
Copy link

thanhpd commented Oct 17, 2018

I've noticed that there are some commits mentioned migrating to npm in place of yarn. Also, yarn.lock file is currently behind package-lock.json.
My suggestions:

  • Update documentation to use npm syntax for installing packages instead of yarn. Running script command from yarn is acceptable and take fewer keystrokes, so please share your thought about this.
  • Delete yarn.lock file to avoid confusion.
@manekinekko
Copy link
Owner

Sounds good to me.

@manekinekko manekinekko added type: feature New feature or request good first issue Good for newcomers Hacktoberfest type: refactor and removed type: feature New feature or request labels Oct 21, 2018
alexbrbr pushed a commit to alexbrbr/angular-search-experience that referenced this issue Oct 25, 2018
chore(install): use npm instead of yarn manekinekko#12
9b199d1
@alexbrbr alexbrbr mentioned this issue Oct 25, 2018
Merged
manekinekko pushed a commit that referenced this issue Oct 29, 2018
@alexbrbr @manekinekko
chore(install): use npm instead of yarn #12 (#18)
4f45417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Hacktoberfest type: refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@manekinekko @thanhpd