Mysql 8.4 #718
Draft
Mysql 8.4 #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nervo
reviewed
Dec 18, 2024
molecule/mysql.8.4/prepare.yml
Outdated
Comment on lines
5
to
7
| hosts: | ||
| - debian.bullseye | ||
| - debian.bookworm |
There was a problem hiding this comment.
Suggested change
| hosts: | |
| - debian.bullseye | |
| - debian.bookworm | |
| hosts: | |
| - debian | |
| - "!debian.buster" |
Permet de simplifier la gestion des releases:
- plus simple pour trouver les cas spéciaux buster
- supporte de fait les futures releases
(à appliquer de partout, bien entendu :) )
There was a problem hiding this comment.
Partout, genre sur tout les rôles ?
There was a problem hiding this comment.
nan, juste pour les tests MySQL 8.4 :)
nervo
reviewed
Dec 18, 2024
| @@ -12,8 +12,8 @@ manala_mysql_install_packages_default: | | |||
| manala_mysql_install_python_packages: | | |||
| {{ | |||
| (ansible_facts.python.version.major == 2) | ternary( | |||
| ['python-mysqldb'], | |||
There was a problem hiding this comment.
Attention, python-mysqldb n'existe que sur buster:
- https://packages.debian.org/buster/python-pymysql
- https://packages.debian.org/buster/python3-pymysql
Il faut aussi s'assurer des versions minimum requises pour python3-mysqldb et voir si ansible gère bien la présence des deux lib en même temps (est-ce qu'il ne va pas privilégier l'ancienne ? faut-il dès lors la supprimer ?)
greedybro
force-pushed
the
mysql/add_8_4
branch
from
1d50324 to
6ec8080
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #681