Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check release label / label_check workflow failure is annoying #3675

Open
3 tasks done
mathbunnyru opened this issue Dec 9, 2024 · 3 comments
Open
3 tasks done

Check release label / label_check workflow failure is annoying #3675

mathbunnyru opened this issue Dec 9, 2024 · 3 comments

Comments

@mathbunnyru
Copy link
Contributor

mathbunnyru commented Dec 9, 2024

Troubleshooting docs

  • My problem is not solved in the Troubleshooting docs

Anaconda default channels

  • I do NOT use the Anaconda default channels (pkgs/* etc.)

How did you install Mamba?

Other (please describe)

Search tried in issue tracker

label, label_check

Latest version of Mamba

  • My problem is not solved with the latest version

Tried in Conda?

Not applicable

Describe your issue

Every time I create a PR, I get the CI failure, because of the label_check workflow.
And I also get an email and notification from GitHub that my build failed.

I think devs with some permissions don't have this issue, but all new contributors do, and that's not pleasant.
Maybe there is a better way?

mamba info / micromamba info

No response

Logs

No response

environment.yml

No response

~/.condarc

No response

@mathbunnyru mathbunnyru changed the title Check release label / label_check workflow is annoying Check release label / label_check workflow failure is annoying Dec 9, 2024
@mathbunnyru
Copy link
Contributor Author

I think it is also makes it less clear which PRs have green CI in PRs list.

@jjerphan
Copy link
Member

jjerphan commented Dec 9, 2024

Yes, I agree.

The best solution I see is to have authors or issues and PRs be able to label theirs.

@JohanMabille
Copy link
Member

The release scripts are based on these labels, so we definitely need this check. Maybe we can provide a PR template that will let the user choose the appropriate label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants