Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on node-fetch #459

Open
lcswillems opened this issue Sep 29, 2023 · 3 comments
Open

Remove dependency on node-fetch #459

lcswillems opened this issue Sep 29, 2023 · 3 comments

Comments

@lcswillems
Copy link

Node 16 is end-of-life. Node 18+ support fetch by default making node-fetch dependency useless.
@lcswillems lcswillems mentioned this issue Sep 30, 2023
Closed
@huw
Copy link
Contributor

huw commented Oct 11, 2023

To maintainers: Arguably a duplicate of #38, more discussion at #401. Will just depend on when you wanna drop Node 16 support (and EoL isn’t necessarily a great reason to do so).

@lcswillems
Copy link
Author

Why EoL might not be a great reason?

@ShivamJoker
Copy link

I am also having error with http module which is not supported in LLRT AWS Lambda.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove node-fetch from Client.ts lcswillems/notion-sdk-js
3 participants
@huw @lcswillems @ShivamJoker