Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use btoa when Buffer isn’t available #464

Closed
wants to merge 1 commit into from
Closed

Conversation

huw
Copy link
Contributor

@huw huw commented Oct 11, 2023

Recreates #461
Fixes #444

@cwang314
Copy link
Contributor

Hey, thanks for opening this PR. We're doing some git history cleanup and need to close the PR as it'll become invalid. Afterwards, please reclone the repo and you can reopen the PR. Thanks for your patience and sincere apologies for the trouble.

@cwang314 cwang314 closed this Jan 24, 2024
@huw
Copy link
Contributor Author

huw commented Jan 24, 2024

Thanks @cwang314. If I may give some feedback, I'm finding it hard to commit to doing even more open source labour for Notion when this PR has been open for months, contains an extremely simple fix to broken functionality, and hasn't even been acknowledged by your team (aside from previously having to re-open it from a previous git history reset). I don't think I will go to the effort of reopening it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buffer.from isn’t supported in all JavaScript runtimes
2 participants