Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #1

Open
4 of 5 tasks
HugoPoi opened this issue Sep 22, 2016 · 0 comments
Open
4 of 5 tasks

Refactoring #1

HugoPoi opened this issue Sep 22, 2016 · 0 comments

Comments

@HugoPoi
Copy link
Member

HugoPoi commented Sep 22, 2016

  • Replace Spooky with phantomjs-node https://github.com/amir20/phantomjs-node
  • Inject CasperJS properly with phantomjs-node or starting CasperJS instead of Phantomjs maybe ...
  • Code refactoring for all then() call
  • Add proper unit test with fake google search engine
  • Increase test coverage
HugoPoi added a commit that referenced this issue Nov 15, 2016
HugoPoi added a commit that referenced this issue Nov 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant