Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion #12

Open
iZakirSheikh opened this issue Jan 28, 2024 · 4 comments
Open

Suggestion #12

iZakirSheikh opened this issue Jan 28, 2024 · 4 comments

Comments

@iZakirSheikh
Copy link

Instead of changing API daily you should thoroughly think it and then publish.
Maybe utilize ChatGPT, Gemini for brainstorming ideas.

@mahozad
Copy link
Owner

mahozad commented Jan 28, 2024

You're right. Thanks for the suggestions and sorry for the constant change.

I think the library is now "complete" and the current API is going to be the final shape for version 1.0.0.
There will probably be just inner optimizations and refactorings for the stable 1.0.0 release.

PS: Have you used the library on iOS? Does it work as expected?

@iZakirSheikh
Copy link
Author

I have used the library in my android app called Audiofy
The app uses version 0.8.0 of ur library.
I think the things that currently Library misses include:

  1. Thumb making.
  2. Loading progress
  3. Provide a way to display chapters like YouTube.

@mahozad
Copy link
Owner

mahozad commented Jan 28, 2024

Thumbs up 👍

  1. Number one relates to Add a shape parameter to WavySliderDefaults.Thumb() #1.
    The Material 3 variant of wavy slider has an overloaded composable function which takes a thumb parameter.
    Have you tried that? Do you need something beyond that?
  2. Could you please clarify what you mean by loading progress?
  3. Making the wavy part segmented like Youtube; doesn't that produce something weird? Do you mean something like Stepped slider galaxygoldfish/waveslider#1 (comment) ?
  4. Number 4 is empty

@iZakirSheikh
Copy link
Author

Actually I am on mobile.
My app currently uses material2. So I can't confirm material3 implementation.

  1. By loading progress I mean the slider should show buffered upto. I.e., how much content have loaded.
    Since this is actually meant to show progress of media, so there should be a way to show stepped progress, chapters etc. we have to brainstorm maybe using figma before building it further.

Sorry for my bad English, actually I am not a native speaker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants