From 8af9d490c5b9cd9b378714d216e0e114f14a6489 Mon Sep 17 00:00:00 2001 From: Dan Wallis Date: Tue, 7 Mar 2023 10:17:09 +0000 Subject: [PATCH 1/3] Remove forbidden @author tag --- .../Adminhtml/Product/Attribute/Set/Toolbar/Main/Filter.php | 3 --- app/code/Magento/Catalog/Block/Adminhtml/Product/Edit.php | 1 - .../Catalog/Block/Adminhtml/Product/Edit/Action/Attribute.php | 2 -- .../Adminhtml/Product/Edit/Action/Attribute/Tab/Attributes.php | 2 -- .../Adminhtml/Product/Edit/Action/Attribute/Tab/Websites.php | 2 -- .../Block/Adminhtml/Product/Edit/Action/Attribute/Tabs.php | 1 - .../Catalog/Block/Adminhtml/Product/Edit/AttributeSet.php | 2 -- .../Catalog/Block/Adminhtml/Product/Edit/NewCategory.php | 2 -- .../Catalog/Block/Adminhtml/Product/Edit/Tab/Alerts.php | 2 -- .../Catalog/Block/Adminhtml/Product/Edit/Tab/Attributes.php | 2 -- .../Block/Adminhtml/Product/Edit/Tab/Attributes/Create.php | 2 -- .../Block/Adminhtml/Product/Edit/Tab/Attributes/Search.php | 2 -- .../Block/Adminhtml/Product/Edit/Tab/Options/Popup/Grid.php | 2 -- .../Adminhtml/Product/Edit/Tab/Options/Type/AbstractType.php | 2 -- .../Block/Adminhtml/Product/Edit/Tab/Options/Type/Date.php | 2 -- .../Block/Adminhtml/Product/Edit/Tab/Options/Type/File.php | 2 -- .../Block/Adminhtml/Product/Edit/Tab/Options/Type/Select.php | 2 -- .../Block/Adminhtml/Product/Edit/Tab/Options/Type/Text.php | 2 -- .../Catalog/Block/Adminhtml/Product/Edit/Tab/Websites.php | 2 -- .../Block/Adminhtml/Product/Frontend/Product/Watermark.php | 2 -- .../Catalog/Block/Adminhtml/Product/Helper/Form/Apply.php | 2 -- .../Catalog/Block/Adminhtml/Product/Helper/Form/Boolean.php | 2 -- .../Catalog/Block/Adminhtml/Product/Helper/Form/Config.php | 2 -- .../Catalog/Block/Adminhtml/Product/Helper/Form/Gallery.php | 2 -- .../Block/Adminhtml/Product/Helper/Form/Gallery/Content.php | 2 -- .../Catalog/Block/Adminhtml/Product/Helper/Form/Image.php | 2 -- .../Magento/Catalog/Block/Adminhtml/Product/Widget/Chooser.php | 2 -- .../Block/Adminhtml/Product/Widget/Chooser/Container.php | 2 -- app/code/Magento/Catalog/Block/Product/Gallery.php | 2 -- app/code/Magento/Catalog/Block/Product/ProductList/Toolbar.php | 1 - app/code/Magento/Catalog/Block/Product/View/Additional.php | 2 -- app/code/Magento/Catalog/Block/Product/View/Attributes.php | 2 -- 32 files changed, 62 deletions(-) diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Set/Toolbar/Main/Filter.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Set/Toolbar/Main/Filter.php index 208003515ade6..df984ece44bba 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Set/Toolbar/Main/Filter.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Set/Toolbar/Main/Filter.php @@ -4,9 +4,6 @@ * See COPYING.txt for license details. */ -/** - * @author Magento Core Team - */ namespace Magento\Catalog\Block\Adminhtml\Product\Attribute\Set\Toolbar\Main; use Magento\Backend\Block\Widget\Form; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit.php index 822580801c4e4..535c09756b5da 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit.php @@ -7,7 +7,6 @@ /** * Customer edit block * - * @author Magento Core Team * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ namespace Magento\Catalog\Block\Adminhtml\Product; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute.php index 82df82d4a3258..8238c56a70390 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute.php @@ -6,8 +6,6 @@ /** * Adminhtml catalog product action attribute update - * - * @author Magento Core Team */ namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Action; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tab/Attributes.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tab/Attributes.php index 287a24e0aaca0..01feaa7edb159 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tab/Attributes.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tab/Attributes.php @@ -6,8 +6,6 @@ /** * Adminhtml catalog product edit action attributes update tab block - * - * @author Magento Core Team */ declare(strict_types=1); diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tab/Websites.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tab/Websites.php index 35c318ee11e65..f4b62ae0a7ca3 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tab/Websites.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tab/Websites.php @@ -6,8 +6,6 @@ /** * Product mass attribute update websites tab - * - * @author Magento Core Team */ namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Action\Attribute\Tab; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tabs.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tabs.php index 2b6d2bef9a3f6..23ea746a5c0c0 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tabs.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tabs.php @@ -9,7 +9,6 @@ * Adminhtml catalog product edit action attributes update tabs block * * @api - * @author Magento Core Team * @since 100.0.2 */ class Tabs extends \Magento\Backend\Block\Widget\Tabs diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/AttributeSet.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/AttributeSet.php index 6419ae2d70588..86e6f068898ce 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/AttributeSet.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/AttributeSet.php @@ -6,8 +6,6 @@ /** * Create product attribute set selector - * - * @author Magento Core Team */ namespace Magento\Catalog\Block\Adminhtml\Product\Edit; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/NewCategory.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/NewCategory.php index ebc269f85d054..3054d4330321e 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/NewCategory.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/NewCategory.php @@ -6,8 +6,6 @@ /** * New category creation form - * - * @author Magento Core Team */ namespace Magento\Catalog\Block\Adminhtml\Product\Edit; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Alerts.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Alerts.php index be9c84ee5edd1..e81f05a1b0a55 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Alerts.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Alerts.php @@ -6,8 +6,6 @@ /** * Product alerts tab - * - * @author Magento Core Team */ namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Tab; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Attributes.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Attributes.php index b25cdd7cb72e4..2316b9f351ab6 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Attributes.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Attributes.php @@ -6,8 +6,6 @@ /** * Product attributes tab - * - * @author Magento Core Team */ namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Tab; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Attributes/Create.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Attributes/Create.php index b0504e4a85320..9b43181163e83 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Attributes/Create.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Attributes/Create.php @@ -6,8 +6,6 @@ /** * New attribute panel on product edit page - * - * @author Magento Core Team */ namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Attributes; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Attributes/Search.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Attributes/Search.php index 702c77e3a5595..f64896f068fcf 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Attributes/Search.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Attributes/Search.php @@ -6,8 +6,6 @@ /** * New attribute panel on product edit page - * - * @author Magento Core Team */ namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Attributes; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Popup/Grid.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Popup/Grid.php index f13cf8907438e..87af39807caf4 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Popup/Grid.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Popup/Grid.php @@ -6,8 +6,6 @@ /** * Adminhtml product grid in custom options popup - * - * @author Magento Core Team */ namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Options\Popup; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/AbstractType.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/AbstractType.php index f9c61f5c81b5f..b29ecbb8d2374 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/AbstractType.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/AbstractType.php @@ -6,8 +6,6 @@ /** * customers defined options - * - * @author Magento Core Team */ namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Options\Type; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/Date.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/Date.php index a0bbc4ad033de..b2930585ece67 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/Date.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/Date.php @@ -6,8 +6,6 @@ /** * customers defined options - * - * @author Magento Core Team */ namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Options\Type; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/File.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/File.php index d3d5f08fa9eae..c9fe6d0ffae2c 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/File.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/File.php @@ -6,8 +6,6 @@ /** * customers defined options - * - * @author Magento Core Team */ namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Options\Type; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/Select.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/Select.php index f6ab5134ae6bd..5b1df12e8fd0b 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/Select.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/Select.php @@ -6,8 +6,6 @@ /** * customers defined options - * - * @author Magento Core Team */ namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Options\Type; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/Text.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/Text.php index e6f78dc3ed169..e85c75532cba5 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/Text.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/Text.php @@ -6,8 +6,6 @@ /** * customers defined options - * - * @author Magento Core Team */ namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Options\Type; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Websites.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Websites.php index 6189a97dbe761..abc679fcf7148 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Websites.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Websites.php @@ -6,8 +6,6 @@ /** * Product Stores tab - * - * @author Magento Core Team */ namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Tab; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Frontend/Product/Watermark.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Frontend/Product/Watermark.php index 7f80aece60ee0..668c1689ab7b2 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Frontend/Product/Watermark.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Frontend/Product/Watermark.php @@ -10,8 +10,6 @@ /** * Fieldset config form element renderer - * - * @author Magento Core Team */ class Watermark extends \Magento\Backend\Block\AbstractBlock implements \Magento\Framework\Data\Form\Element\Renderer\RendererInterface diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Apply.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Apply.php index 101daec2b4906..e7e6cf597ad98 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Apply.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Apply.php @@ -6,8 +6,6 @@ /** * Attribute form apply element - * - * @author Magento Core Team */ namespace Magento\Catalog\Block\Adminhtml\Product\Helper\Form; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Boolean.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Boolean.php index d4461f3d32ac5..8a440da754ef4 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Boolean.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Boolean.php @@ -7,8 +7,6 @@ /** * Product form boolean field helper - * - * @author Magento Core Team */ class Boolean extends \Magento\Framework\Data\Form\Element\Select { diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Config.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Config.php index 16c00aee6beaa..ed81e20406b16 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Config.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Config.php @@ -6,8 +6,6 @@ /** * Adminhtml additional helper block - * - * @author Magento Core Team */ namespace Magento\Catalog\Block\Adminhtml\Product\Helper\Form; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Gallery.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Gallery.php index 36740f5853d74..f3a274b3c47ab 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Gallery.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Gallery.php @@ -6,8 +6,6 @@ /** * Catalog product gallery attribute - * - * @author Magento Core Team */ namespace Magento\Catalog\Block\Adminhtml\Product\Helper\Form; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Gallery/Content.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Gallery/Content.php index b06edc43cd71d..62c7823eb58fb 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Gallery/Content.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Gallery/Content.php @@ -7,8 +7,6 @@ /** * Catalog product form gallery content * - * @author Magento Core Team - * * @method \Magento\Framework\Data\Form\Element\AbstractElement getElement() */ namespace Magento\Catalog\Block\Adminhtml\Product\Helper\Form\Gallery; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Image.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Image.php index 57e82581d83b2..6afa739f918bb 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Image.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Image.php @@ -6,8 +6,6 @@ /** * Product form image field helper - * - * @author Magento Core Team */ namespace Magento\Catalog\Block\Adminhtml\Product\Helper\Form; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Widget/Chooser.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Widget/Chooser.php index 22a56ec0a210d..337c661401671 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Widget/Chooser.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Widget/Chooser.php @@ -6,8 +6,6 @@ /** * Product Chooser for "Product Link" Cms Widget Plugin - * - * @author Magento Core Team */ namespace Magento\Catalog\Block\Adminhtml\Product\Widget; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Widget/Chooser/Container.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Widget/Chooser/Container.php index b8967f1f30e55..c3e10c64805b0 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Widget/Chooser/Container.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Widget/Chooser/Container.php @@ -6,8 +6,6 @@ /** * Chooser Container for "Product Link" Cms Widget Plugin - * - * @author Magento Core Team */ namespace Magento\Catalog\Block\Adminhtml\Product\Widget\Chooser; diff --git a/app/code/Magento/Catalog/Block/Product/Gallery.php b/app/code/Magento/Catalog/Block/Product/Gallery.php index 1f9b0e47fd24e..3de4dc34bfe50 100644 --- a/app/code/Magento/Catalog/Block/Product/Gallery.php +++ b/app/code/Magento/Catalog/Block/Product/Gallery.php @@ -6,8 +6,6 @@ /** * Product gallery - * - * @author Magento Core Team */ namespace Magento\Catalog\Block\Product; diff --git a/app/code/Magento/Catalog/Block/Product/ProductList/Toolbar.php b/app/code/Magento/Catalog/Block/Product/ProductList/Toolbar.php index fffbd052b4fb6..2ae327fa62610 100644 --- a/app/code/Magento/Catalog/Block/Product/ProductList/Toolbar.php +++ b/app/code/Magento/Catalog/Block/Product/ProductList/Toolbar.php @@ -14,7 +14,6 @@ * Product list toolbar * * @api - * @author Magento Core Team * @SuppressWarnings(PHPMD.TooManyFields) * @SuppressWarnings(PHPMD.CouplingBetweenObjects) * @since 100.0.2 diff --git a/app/code/Magento/Catalog/Block/Product/View/Additional.php b/app/code/Magento/Catalog/Block/Product/View/Additional.php index 66527985e41fd..c565744fdc049 100644 --- a/app/code/Magento/Catalog/Block/Product/View/Additional.php +++ b/app/code/Magento/Catalog/Block/Product/View/Additional.php @@ -6,8 +6,6 @@ /** * Product additional info block - * - * @author Magento Core Team */ namespace Magento\Catalog\Block\Product\View; diff --git a/app/code/Magento/Catalog/Block/Product/View/Attributes.php b/app/code/Magento/Catalog/Block/Product/View/Attributes.php index 9fd840b264085..4eec43565def4 100644 --- a/app/code/Magento/Catalog/Block/Product/View/Attributes.php +++ b/app/code/Magento/Catalog/Block/Product/View/Attributes.php @@ -6,8 +6,6 @@ /** * Product description block - * - * @author Magento Core Team */ namespace Magento\Catalog\Block\Product\View; From 1fd8de4d751def67ec28a1814549b9bd25f4434e Mon Sep 17 00:00:00 2001 From: Dan Wallis Date: Tue, 14 Mar 2023 19:31:38 +0000 Subject: [PATCH 2/3] Fix static test failures --- .../Attribute/Set/Toolbar/Main/Filter.php | 2 ++ .../Catalog/Block/Adminhtml/Product/Edit.php | 2 -- .../Adminhtml/Product/Edit/Action/Attribute.php | 7 ++++--- .../Edit/Action/Attribute/Tab/Websites.php | 17 ++++++++++++++--- .../Product/Edit/Action/Attribute/Tabs.php | 2 ++ .../Adminhtml/Product/Edit/AttributeSet.php | 7 +------ .../Block/Adminhtml/Product/Edit/Tab/Alerts.php | 4 ++++ .../Product/Edit/Tab/Attributes/Create.php | 12 +++++++++--- .../Product/Edit/Tab/Attributes/Search.php | 7 +------ .../Product/Edit/Tab/Options/Popup/Grid.php | 7 ++++--- .../Edit/Tab/Options/Type/AbstractType.php | 8 +++++--- .../Product/Edit/Tab/Options/Type/Select.php | 14 ++++++++++---- .../Adminhtml/Product/Edit/Tab/Websites.php | 6 ++---- .../Adminhtml/Product/Helper/Form/Boolean.php | 2 ++ .../Block/Adminhtml/Product/Widget/Chooser.php | 11 +++++++---- .../Catalog/Block/Product/View/Additional.php | 7 ++++--- .../Catalog/Block/Product/View/Attributes.php | 7 ------- 17 files changed, 71 insertions(+), 51 deletions(-) diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Set/Toolbar/Main/Filter.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Set/Toolbar/Main/Filter.php index df984ece44bba..1830e28bdf9ba 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Set/Toolbar/Main/Filter.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Set/Toolbar/Main/Filter.php @@ -34,6 +34,8 @@ public function __construct( } /** + * Prepare the form + * * @return void */ protected function _prepareForm() diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit.php index 535c09756b5da..95bb70732917d 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit.php @@ -31,8 +31,6 @@ class Edit extends \Magento\Backend\Block\Widget protected $_template = 'Magento_Catalog::catalog/product/edit.phtml'; /** - * Core registry - * * @var \Magento\Framework\Registry */ protected $_coreRegistry = null; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute.php index 8238c56a70390..147d8ce8b8e21 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute.php @@ -4,15 +4,14 @@ * See COPYING.txt for license details. */ -/** - * Adminhtml catalog product action attribute update - */ namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Action; use Magento\Catalog\Helper\Product\Edit\Action\Attribute as ActionAttribute; use Magento\Catalog\Model\ResourceModel\Product\Collection; /** + * Adminhtml catalog product action attribute update + * * @api * @since 100.0.2 */ @@ -40,6 +39,8 @@ public function __construct( } /** + * Prepare the layout + * * @return void */ protected function _prepareLayout() diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tab/Websites.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tab/Websites.php index f4b62ae0a7ca3..19469fb593bc0 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tab/Websites.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tab/Websites.php @@ -4,21 +4,22 @@ * See COPYING.txt for license details. */ -/** - * Product mass attribute update websites tab - */ namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Action\Attribute\Tab; use Magento\Store\Model\Group; use Magento\Store\Model\Website; /** + * Product mass attribute update websites tab + * * @api * @since 100.0.2 */ class Websites extends \Magento\Backend\Block\Widget implements \Magento\Backend\Block\Widget\Tab\TabInterface { /** + * Return collection of websites + * * @return Website[] */ public function getWebsiteCollection() @@ -27,6 +28,8 @@ public function getWebsiteCollection() } /** + * Return collection of groups + * * @param Website $website * @return Group[] */ @@ -36,6 +39,8 @@ public function getGroupCollection(Website $website) } /** + * Return collection of stores + * * @param Group $group * @return array */ @@ -55,6 +60,8 @@ public function getTabLabel() } /** + * Return tab title + * * @return \Magento\Framework\Phrase */ public function getTabTitle() @@ -63,6 +70,8 @@ public function getTabTitle() } /** + * Return true always + * * @return bool */ public function canShowTab() @@ -71,6 +80,8 @@ public function canShowTab() } /** + * Return false always + * * @return bool */ public function isHidden() diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tabs.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tabs.php index 23ea746a5c0c0..f41e1d4301ff0 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tabs.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Action/Attribute/Tabs.php @@ -14,6 +14,8 @@ class Tabs extends \Magento\Backend\Block\Widget\Tabs { /** + * Initialise the block + * * @return void */ protected function _construct() diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/AttributeSet.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/AttributeSet.php index 86e6f068898ce..7e8ab0401cecb 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/AttributeSet.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/AttributeSet.php @@ -4,22 +4,17 @@ * See COPYING.txt for license details. */ -/** - * Create product attribute set selector - */ namespace Magento\Catalog\Block\Adminhtml\Product\Edit; use Magento\Framework\App\ObjectManager; use Magento\Framework\Json\Helper\Data as JsonHelper; /** - * Admin AttributeSet block + * Create product attribute set selector */ class AttributeSet extends \Magento\Backend\Block\Widget\Form { /** - * Core registry - * * @var \Magento\Framework\Registry */ protected $_coreRegistry = null; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Alerts.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Alerts.php index e81f05a1b0a55..74ac15bb48cf6 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Alerts.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Alerts.php @@ -17,6 +17,8 @@ class Alerts extends \Magento\Backend\Block\Widget\Tab protected $_template = 'Magento_Catalog::catalog/product/tab/alert.phtml'; /** + * Prepare the layout + * * @return $this */ protected function _prepareLayout() @@ -66,6 +68,8 @@ protected function _prepareLayout() } /** + * Return HTML for accordion + * * @return string */ public function getAccordionHtml() diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Attributes/Create.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Attributes/Create.php index 9b43181163e83..dd7dce34a6f9e 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Attributes/Create.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Attributes/Create.php @@ -4,13 +4,13 @@ * See COPYING.txt for license details. */ -/** - * New attribute panel on product edit page - */ namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Attributes; use Magento\Backend\Block\Widget\Button; +/** + * New attribute panel on product edit page + */ class Create extends Button { /** @@ -35,6 +35,8 @@ public function getConfig() } /** + * Add 'new attribute' button + * * @return $this */ protected function _beforeToHtml() @@ -83,6 +85,8 @@ protected function _beforeToHtml() } /** + * Return the HTML for this block + * * @return string */ protected function _toHtml() @@ -100,6 +104,8 @@ protected function _toHtml() } /** + * Return the JavaScript object name + * * @return string */ public function getJsObjectName() diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Attributes/Search.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Attributes/Search.php index f64896f068fcf..c0e6bd20fa238 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Attributes/Search.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Attributes/Search.php @@ -4,22 +4,17 @@ * See COPYING.txt for license details. */ -/** - * New attribute panel on product edit page - */ namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Attributes; use Magento\Framework\App\ObjectManager; use Magento\Framework\Json\Helper\Data as JsonHelper; /** - * Admin product attribute search block + * New attribute panel on product edit page */ class Search extends \Magento\Backend\Block\Widget { /** - * Core registry - * * @var \Magento\Framework\Registry */ protected $_coreRegistry = null; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Popup/Grid.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Popup/Grid.php index 87af39807caf4..762ec29da021b 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Popup/Grid.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Popup/Grid.php @@ -4,14 +4,13 @@ * See COPYING.txt for license details. */ -/** - * Adminhtml product grid in custom options popup - */ namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Options\Popup; use Magento\Catalog\Model\Product; /** + * Adminhtml product grid in custom options popup + * * @api * @SuppressWarnings(PHPMD.DepthOfInheritance) * @since 100.0.2 @@ -57,6 +56,8 @@ public function _prepareMassaction() } /** + * Prepare the collection + * * @return $this */ protected function _prepareCollection() diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/AbstractType.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/AbstractType.php index b29ecbb8d2374..91c98cda78e70 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/AbstractType.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/AbstractType.php @@ -4,11 +4,11 @@ * See COPYING.txt for license details. */ -/** - * customers defined options - */ namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Options\Type; +/** + * Customers defined options + */ class AbstractType extends \Magento\Backend\Block\Widget { /** @@ -36,6 +36,8 @@ public function __construct( } /** + * Prepare the layout + * * @return $this */ protected function _prepareLayout() diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/Select.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/Select.php index 5b1df12e8fd0b..93399fad6224e 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/Select.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Options/Type/Select.php @@ -4,11 +4,11 @@ * See COPYING.txt for license details. */ -/** - * customers defined options - */ namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Options\Type; +/** + * Customers defined options + */ class Select extends \Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Options\Type\AbstractType { /** @@ -17,7 +17,7 @@ class Select extends \Magento\Catalog\Block\Adminhtml\Product\Edit\Tab\Options\T protected $_template = 'Magento_Catalog::catalog/product/edit/options/type/select.phtml'; /** - * Class constructor + * Initialise the block * * @return void */ @@ -30,6 +30,8 @@ protected function _construct() } /** + * Prepare the layout + * * @return $this */ protected function _prepareLayout() @@ -58,6 +60,8 @@ protected function _prepareLayout() } /** + * Return the HTML for the add button + * * @return string */ public function getAddButtonHtml() @@ -66,6 +70,8 @@ public function getAddButtonHtml() } /** + * Return the HTML for the delete button + * * @return string */ public function getDeleteButtonHtml() diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Websites.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Websites.php index abc679fcf7148..0a1274012b5c9 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Websites.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Websites.php @@ -4,11 +4,11 @@ * See COPYING.txt for license details. */ +namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Tab; + /** * Product Stores tab */ -namespace Magento\Catalog\Block\Adminhtml\Product\Edit\Tab; - class Websites extends \Magento\Backend\Block\Store\Switcher { /** @@ -22,8 +22,6 @@ class Websites extends \Magento\Backend\Block\Store\Switcher protected $_template = 'Magento_Catalog::catalog/product/edit/websites.phtml'; /** - * Core registry - * * @var \Magento\Framework\Registry */ protected $_coreRegistry = null; diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Boolean.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Boolean.php index 8a440da754ef4..812b1dbe908e1 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Boolean.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Helper/Form/Boolean.php @@ -11,6 +11,8 @@ class Boolean extends \Magento\Framework\Data\Form\Element\Select { /** + * Initialise the block + * * @return void */ protected function _construct() diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Widget/Chooser.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Widget/Chooser.php index 337c661401671..a5ffe2a35d0ba 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Widget/Chooser.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Widget/Chooser.php @@ -4,9 +4,6 @@ * See COPYING.txt for license details. */ -/** - * Product Chooser for "Product Link" Cms Widget Plugin - */ namespace Magento\Catalog\Block\Adminhtml\Product\Widget; use Magento\Backend\Block\Widget\Grid; @@ -14,6 +11,9 @@ use Magento\Backend\Block\Widget\Grid\Extended; use Magento\Framework\Data\Form\Element\AbstractElement; +/** + * Product Chooser for "Product Link" Cms Widget Plugin + */ class Chooser extends Extended { /** @@ -147,6 +147,8 @@ public function getCheckboxCheckCallback() $(grid.containerId).fire('product:changed', {element: element}); }"; } + + return ''; } /** @@ -183,6 +185,8 @@ function (grid, event) { } '; } + + return ''; } /** @@ -238,7 +242,6 @@ protected function _prepareCollection() if ($categoryId = $this->getCategoryId()) { $category = $this->_categoryFactory->create()->load($categoryId); if ($category->getId()) { - // $collection->addCategoryFilter($category); $productIds = $category->getProductsPosition(); $productIds = array_keys($productIds); if (empty($productIds)) { diff --git a/app/code/Magento/Catalog/Block/Product/View/Additional.php b/app/code/Magento/Catalog/Block/Product/View/Additional.php index c565744fdc049..801f42a0319cd 100644 --- a/app/code/Magento/Catalog/Block/Product/View/Additional.php +++ b/app/code/Magento/Catalog/Block/Product/View/Additional.php @@ -4,12 +4,11 @@ * See COPYING.txt for license details. */ -/** - * Product additional info block - */ namespace Magento\Catalog\Block\Product\View; /** + * Product additional info block + * * @api * @since 100.0.2 */ @@ -26,6 +25,8 @@ class Additional extends \Magento\Framework\View\Element\Template protected $_template = 'Magento_Catalog::product/view/additional.phtml'; /** + * Return the HTML for the child list + * * @return array */ public function getChildHtmlList() diff --git a/app/code/Magento/Catalog/Block/Product/View/Attributes.php b/app/code/Magento/Catalog/Block/Product/View/Attributes.php index 4eec43565def4..5a65736299ad1 100644 --- a/app/code/Magento/Catalog/Block/Product/View/Attributes.php +++ b/app/code/Magento/Catalog/Block/Product/View/Attributes.php @@ -4,9 +4,6 @@ * See COPYING.txt for license details. */ -/** - * Product description block - */ namespace Magento\Catalog\Block\Product\View; use Magento\Catalog\Model\Product; @@ -14,8 +11,6 @@ use Magento\Framework\Pricing\PriceCurrencyInterface; /** - * Attributes attributes block - * * @api * @since 100.0.2 */ @@ -27,8 +22,6 @@ class Attributes extends \Magento\Framework\View\Element\Template protected $_product = null; /** - * Core registry - * * @var \Magento\Framework\Registry */ protected $_coreRegistry = null; From b25819d3c72d90001590355ae865b2ac35ed4944 Mon Sep 17 00:00:00 2001 From: engcom-Echo Date: Thu, 27 Jun 2024 09:22:19 +0530 Subject: [PATCH 3/3] Fixed static test failures --- app/code/Magento/Catalog/Block/Adminhtml/Product/Edit.php | 1 + .../Magento/Catalog/Block/Product/ProductList/Toolbar.php | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit.php b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit.php index 95bb70732917d..2b1f6eb169af8 100644 --- a/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit.php +++ b/app/code/Magento/Catalog/Block/Adminhtml/Product/Edit.php @@ -291,6 +291,7 @@ public function getDuplicateUrl() * Retrieve product header * * @deprecated 102.0.0 + * @see nothing * @return string */ public function getHeader() diff --git a/app/code/Magento/Catalog/Block/Product/ProductList/Toolbar.php b/app/code/Magento/Catalog/Block/Product/ProductList/Toolbar.php index 2ae327fa62610..60eee98b68768 100644 --- a/app/code/Magento/Catalog/Block/Product/ProductList/Toolbar.php +++ b/app/code/Magento/Catalog/Block/Product/ProductList/Toolbar.php @@ -77,6 +77,7 @@ class Toolbar extends \Magento\Framework\View\Element\Template /** * @var bool $_paramsMemorizeAllowed * @deprecated 103.0.1 + * @see nothing */ protected $_paramsMemorizeAllowed = true; @@ -93,6 +94,7 @@ class Toolbar extends \Magento\Framework\View\Element\Template /** * @var \Magento\Catalog\Model\Session * @deprecated 103.0.1 + * @see nothing */ protected $_catalogSession; @@ -182,6 +184,7 @@ public function __construct( * * @return $this * @deprecated 103.0.1 + * @see nothing */ public function disableParamsMemorizing() { @@ -196,6 +199,7 @@ public function disableParamsMemorizing() * @param mixed $value parameter value * @return $this * @deprecated 103.0.1 + * @see nothing */ protected function _memorizeParam($param, $value) {